Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove types deriving from JsonTypeInfo<T> and mark as sealed. #81306

Merged

Conversation

eiriktsarpalis
Copy link
Member

Removes a number of generic types deriving from JsonTypeInfo<T> and marks the type itself as sealed. It also removes a number of abstract and virtual methods that were being used to perform delayed metadata resolution. The type itself should now only contain data and caches, with any metadata resolution logic being moved out to static factory methods.

Contributes to #80917.

cc @eerhardt

@dotnet-issue-labeler
Copy link

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@ghost ghost assigned eiriktsarpalis Jan 28, 2023
@ghost
Copy link

ghost commented Jan 28, 2023

Tagging subscribers to this area: @dotnet/area-system-text-json, @gregsdennis
See info in area-owners.md if you want to be subscribed.

Issue Details

Removes a number of generic types deriving from JsonTypeInfo<T> and marks the type itself as sealed. It also removes a number of abstract and virtual methods that were being used to perform delayed metadata resolution. The type itself should now only contain data and caches, with any metadata resolution logic being moved out to static factory methods.

Contributes to #80917.

cc @eerhardt

Author: eiriktsarpalis
Assignees: -
Labels:

area-System.Text.Json, new-api-needs-documentation

Milestone: -

@eiriktsarpalis eiriktsarpalis added the size-reduction Issues impacting final app size primary for size sensitive workloads label Jan 28, 2023
@eiriktsarpalis eiriktsarpalis added this to the 8.0.0 milestone Jan 28, 2023
@ghost
Copy link

ghost commented Jan 28, 2023

Tagging subscribers to 'size-reduction': @eerhardt, @SamMonoRT, @marek-safar
See info in area-owners.md if you want to be subscribed.

Issue Details

Removes a number of generic types deriving from JsonTypeInfo<T> and marks the type itself as sealed. It also removes a number of abstract and virtual methods that were being used to perform delayed metadata resolution. The type itself should now only contain data and caches, with any metadata resolution logic being moved out to static factory methods.

Contributes to #80917.

cc @eerhardt

Author: eiriktsarpalis
Assignees: eiriktsarpalis
Labels:

area-System.Text.Json, new-api-needs-documentation, size-reduction

Milestone: -

@ghost ghost locked as resolved and limited conversation to collaborators Mar 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-System.Text.Json new-api-needs-documentation size-reduction Issues impacting final app size primary for size sensitive workloads
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants