[QUIC] Added tests to check IsSupported. #81481
Conversation
ManickaP
added
the
NO-MERGE
ghost
assigned 
|
Tagging subscribers to this area: @dotnet/ncl Issue DetailsOn Windows, straightforward. On Linux, I'm probing system for libmsquic existence and if so then checking Contributes to #81447 Adding NO MERGE as this should fail now on Win11.
|
|
Thinking about this some more and I think we should be more aggressive. On Linux, on every docker image, we should expect |
src/libraries/System.Net.Quic/tests/FunctionalTests/MsQuicPlatformDetectionTests.cs
Show resolved
Hide resolved
src/libraries/System.Net.Quic/tests/FunctionalTests/MsQuicPlatformDetectionTests.cs
Outdated
Show resolved
Hide resolved
ManickaP
force-pushed
the
mapichov/quic-test-supported
branch
from
cf63fb4
to
b1615d8
Compare
This comment was marked as off-topic.
This comment was marked as off-topic.
| @@ -20,20 +21,33 @@ public void UnsupportedPlatforms_ThrowsPlatformNotSupportedException() | |||
| Assert.ThrowsAsync<PlatformNotSupportedException>(async () => await CreateQuicConnection(new IPEndPoint(IPAddress.Loopback, 0))); | |||
| } | |||
|
|
|||
| [ActiveIssue("https://github.com/dotnet/runtime/issues/73290", typeof(PlatformDetection), nameof(PlatformDetection.IsSingleFile))] | |||
There was a problem hiding this comment.
Based on this run: https://dev.azure.com/dnceng-public/public/_build/results?buildId=158551&view=ms.vss-test-web.build-test-results-tab&runId=3276022&resultId=132009&paneView=debug
it looks like this part works.
why? |
Ohh we don't, you have too many PRs named "update msquic" 😄 We need to pull in microsoft/msquic#3394 for alpine, which was merged into transport in dotnet/msquic#120. Do we know if it got propagated into the helix images already? |
ManickaP
force-pushed
the
mapichov/quic-test-supported
branch
from
9b49aae
to
bac381e
Compare
|
|
|
the image tags are waiting for dotnet/dotnet-buildtools-prereqs-docker#790. Should hopefully happen today. |
ManickaP
force-pushed
the
mapichov/quic-test-supported
branch
from
bac381e
to
f9241c4
Compare
ManickaP
force-pushed
the
mapichov/quic-test-supported
branch
from
73de4ae
to
2ea6ef0
Compare
|
/azp run runtime-extra-platforms |
|
/azp run runtime-libraries-coreclr outerloop |
|
/azp run runtime-extra-platforms |
|
/azp run runtime-libraries-coreclr outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
1 similar comment
|
Azure Pipelines successfully started running 1 pipeline(s). |
| @@ -52,6 +55,7 @@ public static partial class PlatformDetection | |||
| public static bool IsRedHatFamily => IsRedHatFamilyAndVersion(); | |||
| public static bool IsNotRedHatFamily => !IsRedHatFamily; | |||
| public static bool IsRedHatFamily7 => IsRedHatFamilyAndVersion(7); | |||
| public static bool IsCentos7 => IsDistroAndVersion("centos", 7); | |||
There was a problem hiding this comment.
can we use the IsRedHatFamily7 above?
There was a problem hiding this comment.
It includes RHEL (or rather excludes from testing) as well. So no, I don't think that's advisable as we want exact list of images that are failing.
There was a problem hiding this comment.
they should be basically identical. but I guess they are not:
dotnet/arcade#10253 (comment)
Perhaps something we should investigate. We have at least one of the runs in container so it should be easy to check.
|
Errors unrelated:
|
|
This is ready for review: @CarnaViire @wfurt |
ManickaP
removed
the
NO-MERGE
On Windows, straightforward.
On Linux, I'm probing system for libmsquic existence and if so then checking
IsSupported. This should discover installed libmsquic without corresponding dependencies like openssl.I'm also adding test that expects libmsquic on every tested Linux we have in the matrix and suppressing for known gaps.
Contributes to #81447