JIT: Avoid omitting copies for struct fields passed implicitly by reference #81787
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The code does not properly mark the parent struct as address exposed, but also doing so would completely disable any tracking/optimization for these locals which we do not want to do. Fix dotnet#81739
dotnet-issue-labeler
bot
added
the
area-CodeGen-coreclr
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch, @kunalspathak Issue DetailsThe code does not properly mark the parent struct as address exposed, but also doing so would completely disable any tracking/optimization for these locals which we do not want to do. Fix #81739
|
|
/azp run runtime-coreclr superpmi-replay |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Only some diffs in a few tests. cc @dotnet/jit-contrib PTAL @EgorBo |
tannergooding
approved these changes
Feb 8, 2023
jakobbotsch
deleted the
last-use-copy-elision-check-promoted-struct-fields
branch
This was referenced Feb 8, 2023
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code does not properly mark the parent struct as address exposed, but also doing so would completely disable any tracking/optimization for these locals which we do not want to do.
Fix #81739