Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[mono][interp] Intrinsify CreateSpan #82093

Merged
merged 2 commits into from Feb 15, 2023
Merged

[mono][interp] Intrinsify CreateSpan #82093

merged 2 commits into from Feb 15, 2023
+51 −23

Conversation

BrzVlad
Copy link
Member

@BrzVlad BrzVlad commented Feb 14, 2023

Fixes #80762

@BrzVlad
Copy link
Member Author

BrzVlad commented Feb 14, 2023

cc @jandupej

@ghost ghost assigned BrzVlad Feb 14, 2023
@ghost
Copy link

ghost commented Feb 14, 2023

Tagging subscribers to this area: @BrzVlad, @kotlarmilos
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #80762

Author: BrzVlad
Assignees: -
Labels:

area-Codegen-Interpreter-mono
Milestone: -

@build-analysis build-analysis bot mentioned this pull request Feb 14, 2023
Closed
kotlarmilos
kotlarmilos reviewed Feb 15, 2023
View reviewed changes
Copy link
Member

@kotlarmilos kotlarmilos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jandupej
Copy link
Member

Also LGTM.

@lewing
Copy link
Member

lewing commented Feb 15, 2023

failure is known

@lewing lewing merged commit a979774 into dotnet:main Feb 15, 2023
This was referenced Feb 21, 2023
Closed
Closed
Closed
Closed
Closed
Closed
Closed
@lewing lewing mentioned this pull request Feb 21, 2023
Open
@radekdoulik radekdoulik mentioned this pull request Feb 22, 2023
Open
@dotnet dotnet locked as resolved and limited conversation to collaborators Mar 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kotlarmilos kotlarmilos kotlarmilos left review comments

@lewing lewing lewing approved these changes

@vargaz vargaz vargaz approved these changes

@pavelsavara pavelsavara Awaiting requested review from pavelsavara pavelsavara is a code owner

Assignees

@BrzVlad BrzVlad

Labels
area-Codegen-Interpreter-mono
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Intrinsify RuntimeHelpers.CreateSpan on Mono
5 participants
@BrzVlad @jandupej @lewing @vargaz @kotlarmilos