Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[wasi] Add WasiAppBuilder task #82126

Merged
merged 6 commits into from
Feb 22, 2023
Merged

[wasi] Add WasiAppBuilder task #82126

merged 6 commits into from
Feb 22, 2023

Conversation

radical
Copy link
Member

@radical radical commented Feb 14, 2023

  • and some fixes for WasmAppHost

@radical radical added arch-wasm WebAssembly architecture area-Build-mono os-wasi Related to WASI variant of arch-wasm labels Feb 14, 2023
@ghost ghost assigned radical Feb 14, 2023
@ghost
Copy link

ghost commented Feb 14, 2023

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details
  • and some fixes for WasmAppHost
Author: radical
Assignees: -
Labels:

arch-wasm, area-Build-mono, os-wasi
Milestone: -

@radical radical added the NO-REVIEW Experimental/testing PR, do NOT review it label Feb 14, 2023
@radical radical marked this pull request as ready for review February 16, 2023 04:12
@radical radical removed the NO-REVIEW Experimental/testing PR, do NOT review it label Feb 16, 2023
@radical radical requested a review from kg as a code owner February 21, 2023 20:45
pavelsavara
pavelsavara approved these changes Feb 22, 2023
View reviewed changes
src/tasks/WasmAppBuilder/WasmAppBuilderBaseTask.cs
@@ -65,6 +66,25 @@ public override bool Execute()

protected abstract bool ExecuteInternal();

protected virtual bool ValidateArguments() => true;

protected void ProcessSatelliteAssemblies(Action<(string fullPath, string culture)> fn)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: please rename the callback to express what it does.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll include it in the follow up PR.

src/tasks/WasmAppBuilder/wasi/WasiAppBuilder.cs Show resolved Hide resolved
@radical radical merged commit 134de4b into dotnet:main Feb 22, 2023
@radical radical deleted the wasi-next branch February 22, 2023 16:29
@ghost ghost locked as resolved and limited conversation to collaborators Mar 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pavelsavara pavelsavara pavelsavara approved these changes

@lewing lewing Awaiting requested review from lewing lewing is a code owner

@marek-safar marek-safar Awaiting requested review from marek-safar

@kg kg Awaiting requested review from kg

Assignees

@radical radical

Labels
arch-wasm WebAssembly architecture area-Build-mono os-wasi Related to WASI variant of arch-wasm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@radical @pavelsavara