Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[jiterp] Adjust jiterpreter thresholds to exercise it more on CI #82476

Closed
wants to merge 6 commits into from

Conversation

kg
Copy link
Contributor

@kg kg commented Feb 22, 2023

Test PR in order to run CI lanes with the jiterpreter thresholds lower for better test coverage. If this works well ideally we can set up a lane for this or a rolling build or something.

@kg kg added NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) arch-wasm WebAssembly architecture area-Codegen-Jiterpreter-mono labels Feb 22, 2023
@ghost ghost assigned kg Feb 22, 2023
@ghost
Copy link

ghost commented Feb 22, 2023

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

Test PR in order to run CI lanes with the jiterpreter thresholds lower for better test coverage. If this works well ideally we can set up a lane for this or a rolling build or something.

Author: kg
Assignees: -
Labels:

NO-MERGE, arch-wasm, area-Codegen-Jiterpreter-mono

Milestone: -

kg added 6 commits March 9, 2023 17:02
Generate fallthrough in CFG

Generate branch block header partially in cfg

Emit branches in CFG

Checkpoint: Emit loop and exit return in CFG (broken)

Fix CFG emitting function header in the wrong place

Improve accuracy of cfg size estimation

Remove log messages

Checkpoint: Forward branches partially working

Fix non-conditional branches not being added to target table
Remove fallthrough
Use copyWithin to implement appendBytes where possible
More accurate overhead calculation
@kg kg force-pushed the wasm-jiterp-low-threshold branch from e6bf444 to ceba516 Compare March 10, 2023 15:21
@ghost ghost closed this Apr 9, 2023
@ghost
Copy link

ghost commented Apr 9, 2023

Draft Pull Request was automatically closed for 30 days of inactivity. Please let us know if you'd like to reopen it.

@dotnet dotnet locked as resolved and limited conversation to collaborators May 9, 2023
@dotnet dotnet unlocked this conversation May 19, 2023
@dotnet dotnet locked as resolved and limited conversation to collaborators Jun 18, 2023
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
arch-wasm WebAssembly architecture NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant