Use throw helpers in a few more places #82533

stephentoub · 2023-02-23T16:38:52Z

No description provided.

src/libraries/System.Private.CoreLib/src/System/String.cs

xtqqczze

Don't forgot the nullable annotations :)

src/libraries/System.IO.Compression.Brotli/src/System/IO/Compression/BrotliStream.cs

...aries/System.IO.Compression/src/System/IO/Compression/DeflateManaged/DeflateManagedStream.cs

src/libraries/System.IO.Compression/src/System/IO/Compression/DeflateZLib/DeflateStream.cs

src/libraries/System.IO.Compression/src/System/IO/Compression/GZipStream.cs

src/libraries/System.IO.Compression/src/System/IO/Compression/ZLibStream.cs

src/libraries/System.Private.CoreLib/src/System/String.cs

src/mono/System.Private.CoreLib/src/System/GC.Mono.cs

xtqqczze · 2023-02-23T17:52:17Z

I believe MemberNotNullAttribute may provide a benefit similar to DoesNotReturnAttribute, as code analysis can determine the method will not return when the member is null.

stephentoub · 2023-02-23T17:56:28Z

I believe MemberNotNullAttribute may provide a benefit similar to DoesNotReturnAttribute, as code analysis can determine the method will not return when the member is null.

These methods are private. If the caller doesn't try to dereference the cited member, such attribution doesn't help with anything.

drieseng · 2023-02-25T08:21:07Z

src/libraries/System.Private.CoreLib/src/System/String.cs

@@ -295,13 +295,19 @@ private static unsafe string Ctor(ReadOnlySpan<char> value)

        public static string Create<TState>(int length, TState state, SpanAction<char, TState> action)
        {
-            ArgumentNullException.ThrowIfNull(action);
+            if (action is null)


@stephentoub: Just out of curiosity, why was this changed?

PS. I should sleep more :(

This pattern results in ever so slightly smaller asm, and as it's in a generic method and we already had the helper and the appropriately named constant argument and I was already editing the method, it was trivial to switch.

Use throw helpers in a few more places

a56b721

stephentoub requested a review from marek-safar as a code owner February 23, 2023 16:38

ghost assigned stephentoub Feb 23, 2023

tannergooding reviewed Feb 23, 2023

View reviewed changes

src/libraries/System.Private.CoreLib/src/System/String.cs Outdated Show resolved Hide resolved

tannergooding approved these changes Feb 23, 2023

View reviewed changes

stephentoub commented Feb 23, 2023

View reviewed changes

src/libraries/System.Private.CoreLib/src/System/String.cs Outdated Show resolved Hide resolved

Update src/libraries/System.Private.CoreLib/src/System/String.cs

39989d8

xtqqczze reviewed Feb 23, 2023

View reviewed changes

Add missing cast

3298c13

stephentoub merged commit f8b9b8d into dotnet:main Feb 23, 2023

stephentoub deleted the morethrowhelper branch February 23, 2023 23:00

drieseng reviewed Feb 25, 2023

View reviewed changes

dotnet locked as resolved and limited conversation to collaborators Mar 27, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use throw helpers in a few more places #82533

Use throw helpers in a few more places #82533

stephentoub commented Feb 23, 2023

xtqqczze left a comment

xtqqczze commented Feb 23, 2023

stephentoub commented Feb 23, 2023

drieseng Feb 25, 2023 •

edited

stephentoub Feb 25, 2023 •

edited

Use throw helpers in a few more places #82533

Use throw helpers in a few more places #82533

Conversation

stephentoub commented Feb 23, 2023

xtqqczze left a comment

Choose a reason for hiding this comment

xtqqczze commented Feb 23, 2023

stephentoub commented Feb 23, 2023

drieseng Feb 25, 2023 • edited

Choose a reason for hiding this comment

stephentoub Feb 25, 2023 • edited

Choose a reason for hiding this comment

drieseng Feb 25, 2023 •

edited

stephentoub Feb 25, 2023 •

edited