Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JIT: Remove JTRUE(relop) invariant in the backend #82766

Merged
merged 9 commits into from
Mar 7, 2023
Merged

JIT: Remove JTRUE(relop) invariant in the backend #82766

merged 9 commits into from
Mar 7, 2023

Commits on Mar 1, 2023

  1. JIT: Remove JTRUE(relop) invariant in the backend 

    Today the backend (and much of the JIT) allows only JTRUE with a relop
operand, and it is always assumed that this relop appears right before
JTRUE in linear order. This change adds support for JTRUE nodes with
arbitrary integral operands from lowering and onwards. The operand is
also allowed to appear at arbitrary locations in LIR.

With this, we can now enable an optimization that turns
EQ/NE(relop/SETCC, 0) into just a (potentially) reversed condition. This
improves codegen for some cases with SELECTCC and gives us a simple way
to allow for compare chains that feed conditional branches in the
future.
    @jakobbotsch
    jakobbotsch committed Mar 1, 2023
    Configuration menu
    Copy the full SHA
    dd46020 View commit details
    Browse the repository at this point in the history

Commits on Mar 2, 2023

  1. Small cleanups

    @jakobbotsch
    jakobbotsch committed Mar 2, 2023
    Configuration menu
    Copy the full SHA
    8996239 View commit details
    Browse the repository at this point in the history

  2. Add GT_JTRUE case in arm arch codegen

    @jakobbotsch
    jakobbotsch committed Mar 2, 2023
    Configuration menu
    Copy the full SHA
    e6e2be0 View commit details
    Browse the repository at this point in the history

Commits on Mar 3, 2023

  1. Apply suggestions from code review

    @jakobbotsch
    jakobbotsch committed Mar 3, 2023
    Configuration menu
    Copy the full SHA
    0e30f7e View commit details
    Browse the repository at this point in the history

Commits on Mar 6, 2023

  1. Add some JITDUMP for the new transform

    @jakobbotsch
    jakobbotsch committed Mar 6, 2023
    Configuration menu
    Copy the full SHA
    c86cb43 View commit details
    Browse the repository at this point in the history

  2. Handle flags in GetMarkedRange instead; add GT_SELECT, GT_JTRUE jitdump

    @jakobbotsch
    jakobbotsch committed Mar 6, 2023
    Configuration menu
    Copy the full SHA
    32cb893 View commit details
    Browse the repository at this point in the history

  3. Fix build

    @jakobbotsch
    jakobbotsch committed Mar 6, 2023
    Configuration menu
    Copy the full SHA
    091bc1a View commit details
    Browse the repository at this point in the history

  4. Fix a function header

    @jakobbotsch
    jakobbotsch committed Mar 6, 2023
    Configuration menu
    Copy the full SHA
    cd38ea4 View commit details
    Browse the repository at this point in the history

  5. Update function header

    @jakobbotsch
    jakobbotsch committed Mar 6, 2023
    Configuration menu
    Copy the full SHA
    13a5c89 View commit details
    Browse the repository at this point in the history