Another attempt to fix stress tests #83211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @dotnet/ncl Issue DetailsAttempt to fix #82528, using a workaround from actions/runner-images#7080 (comment).
|
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
1 similar comment
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
1 similar comment
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
|
/azp run runtime-libraries stress-ssl |
|
/azp run runtime-libraries stress-http |
|
Azure Pipelines successfully started running 1 pipeline(s). |
1 similar comment
|
Azure Pipelines successfully started running 1 pipeline(s). |
antonfirsov
commented
Mar 13, 2023
Comment on lines
+20
to
+23
| $dockerComposeCmd = $env:DOCKER_COMPOSE_CMD | ||
| if (!(Test-Path $dockerComposeCmd)) { | ||
| $dockerComposeCmd = "docker-compose" | ||
| } |
There was a problem hiding this comment.
This is now an asymmetry between run-docker-compose.ps1 in SslStress vs HttpStress.
For some reason, the HttpStress pipeline is ok to docker-compose build with V1 of compose but then do the run with V2, however in SslStress this resulted in a failure.
I don't want to add an equivalent workaround to run-docker-compose.ps1 in HttpStress, when it's not necessary.
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tried using another Windows image, which did not work (#82736), so decided to go with the workaround from actions/runner-images#7080 (comment) to fix #82528.