Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JIT: Add a (disabled) prototype for a generalized promotion pass #83388

Merged
merged 57 commits into from
Apr 11, 2023

Merge branch 'main' of github.com:dotnet/runtime into generalized-pro…

ea2786d
Select commit
Failed to load commit list.
Merged

JIT: Add a (disabled) prototype for a generalized promotion pass #83388

Merge branch 'main' of github.com:dotnet/runtime into generalized-pro…
ea2786d
Select commit
Failed to load commit list.
Build Analysis / Build Analysis succeeded Apr 7, 2023 in 0s

.NET Result Analysis

Details

All checks completed

[runtime]

[runtime-coreclr superpmi-diffs]

[runtime-coreclr superpmi-replay]

[runtime-dev-innerloop]

[dotnet-linker-tests]

[runtime-staging]

Build Rerun

✔️ Build passed after 1 retries.

(Attempt #1) [link to build]

runtime / Build / Libraries Test Run release coreclr windows x86 Release / Send to Helix

[:construction: Report infrastructure issue] [:page_facing_up: Report repository issue]
    ❌.packages\microsoft.dotnet.helix.sdk\8.0.0-beta.23177.4\tools\azure-pipelines\AzurePipelines.MultiQueue.targets(42,5): error : (NETCORE_ENGINEERING_TELEMETRY=Test) Test System.Text.RegularExpressions.Tests.RegexMatchTests.Match_TestThatTimeoutHappens has failed. Check the Test tab for details.

runtime / Build / Libraries Test Run release coreclr windows x64 Debug / Send to Helix

[:construction: Report infrastructure issue] [:page_facing_up: Report repository issue]
    ❌.packages\microsoft.dotnet.helix.sdk\8.0.0-beta.23177.4\tools\azure-pipelines\AzurePipelines.MultiQueue.targets(42,5): error : (NETCORE_ENGINEERING_TELEMETRY=Test) Test Microsoft.Extensions.Hosting.WindowsServiceLifetimeTests.ServiceCanStopItself has failed. Check the Test tab for details.

Non-Deterministic Test Failures Detected

❌ DataContractSerializerTests.DCS_FileStreamSurrogate [Details] [3.70% failure rate]
[:construction: Report test infrastructure issue] [:page_facing_up: Report test repository issue]

Failing Configurations (2)

  • Ubuntu.2004.Amd64
  • Windows.Amd64.Server2022.Open
Exception Message
System.IO.DirectoryNotFoundException : Could not find a part of the path '/tmp/i4s2yvhh.2m2_DCS_FileStreamSurrogate_4046'.
CallStack
   at Interop.ThrowExceptionForIoErrno(ErrorInfo , String , Boolean )
   at Interop.CheckIo(Error , String , Boolean )
   at Microsoft.Win32.SafeHandles.SafeFileHandle.Open(String , OpenFlags , Int32 , Func`4 )
   at Microsoft.Win32.SafeHandles.SafeFileHandle.Open(String , FileMode , FileAccess , FileShare , FileOptions , Int64 , UnixFileMode , Int64& , UnixFileMode& , Func`4 )
   at Microsoft.Win32.SafeHandles.SafeFileHandle.Open(String , FileMode , FileAccess , FileShare , FileOptions , Int64 , Nullable`1 , Func`4 )
   at System.IO.Strategies.OSFileStreamStrategy..ctor(String , FileMode , FileAccess , FileShare , FileOptions , Int64 , Nullable`1 )
   at System.IO.Strategies.UnixFileStreamStrategy..ctor(String , FileMode , FileAccess , FileShare , FileOptions , Int64 , Nullable`1 )
   at System.IO.Strategies.FileStreamHelpers.ChooseStrategyCore(String , FileMode , FileAccess , FileShare , FileOptions , Int64 , Nullable`1 )
   at System.IO.Strategies.FileStreamHelpers.ChooseStrategy(FileStream , String , FileMode , FileAccess , FileShare , Int32 , FileOptions , Int64 , Nullable`1 )
   at System.IO.FileStream..ctor(String , FileMode , FileAccess , FileShare , Int32 , FileOptions , Int64 )
   at System.IO.FileStream..ctor(String , FileMode , FileAccess , FileShare , Int32 , FileOptions )
   at System.IO.FileStream..ctor(String , FileMode , FileAccess , FileShare , Int32 , Boolean )
   at System.IO.FileStream..ctor(String , FileMode , FileAccess , FileShare )
   at MyFileStream..ctor(String fileName)
   at DataContractSerializerTests.DCS_FileStreamSurrogate()
   at System.Reflection.MethodInvoker.InterpretedInvoke(Object , IntPtr* )
   at System.Reflection.MethodInvoker.Invoke(Object , IntPtr* , BindingFlags )
❌ DataContractSerializerTests.DCS_MemoryStream_Deserialize_CompatibleWithFullFramework [Details] [1.90% failure rate]
[:construction: Report test infrastructure issue] [:page_facing_up: Report test repository issue]

Failing Configurations (2)

  • Ubuntu.2004.Amd64
  • Windows.Amd64.Server2022.Open
Exception Message
System.NullReferenceException : Object reference not set to an instance of an object.
CallStack
   at System.Runtime.Serialization.MemoryStreamAdapter.GetMemoryStream(MemoryStreamAdapter value)
   at System.Runtime.Serialization.ReflectionReader.ResolveAdapterObject(Object )
   at System.Runtime.Serialization.ReflectionReader.ReflectionReadClass(XmlReaderDelegator , XmlObjectSerializerReadContext , XmlDictionaryString[] , XmlDictionaryString[] , ClassDataContract )
   at System.Runtime.Serialization.ReflectionXmlClassReader.ReflectionReadClass(XmlReaderDelegator , XmlObjectSerializerReadContext , XmlDictionaryString[] , XmlDictionaryString[] )
   at System.Runtime.Serialization.DataContracts.ClassDataContract.ReadXmlValue(XmlReaderDelegator , XmlObjectSerializerReadContext )
   at System.Runtime.Serialization.XmlObjectSerializerReadContext.ReadDataContractValue(DataContract , XmlReaderDelegator )
   at System.Runtime.Serialization.XmlObjectSerializerReadContext.InternalDeserialize(XmlReaderDelegator reader, String name, String ns, Type declaredType, DataContract& dataContract)
   at System.Runtime.Serialization.XmlObjectSerializerReadContext.InternalDeserialize(XmlReaderDelegator xmlReader, Type declaredType, DataContract dataContract, String name, String ns)
   at System.Runtime.Serialization.DataContractSerializer.InternalReadObject(XmlReaderDelegator xmlReader, Boolean verifyObjectName, DataContractResolver dataContractResolver)
   at System.Runtime.Serialization.XmlObjectSerializer.ReadObjectHandleExceptions(XmlReaderDelegator reader, Boolean verifyObjectName, DataContractResolver dataContractResolver)
   at System.Runtime.Serialization.XmlObjectSerializer.ReadObjectHandleExceptions(XmlReaderDelegator reader, Boolean verifyObjectName)
   at System.Runtime.Serialization.DataContractSerializer.ReadObject(XmlReader )
   at DataContractSerializerTests.<DCS_MemoryStream_Deserialize_CompatibleWithFullFramework>g__DeserializeObjectAndValidate|241_0(String input, Byte[] expectedData, Int32 expectedPosition, Boolean expectedExposable, Boolean expectedWritable)
   at DataContractSerializerTests.DCS_MemoryStream_Deserialize_CompatibleWithFullFramework()
   at System.Reflection.MethodInvoker.InterpretedInvoke(Object , IntPtr* )
   at System.Reflection.MethodInvoker.Invoke(Object , IntPtr* , BindingFlags )
❌ DataContractSerializerTests.DCS_MemoryStream_Serialize_UsesBuiltInAdapter [Details] [3.80% failure rate]
[:construction: Report test infrastructure issue] [:page_facing_up: Report test repository issue]

Failing Configurations (2)

  • Ubuntu.2004.Amd64
  • Windows.Amd64.Server2022.Open
Exception Message
XML comparison is also failing
Test failed for input: System.IO.MemoryStream
Expected: <MemoryStream xmlns:i="http://www.w3.org/2001/XMLSchema-instance" xmlns="http://schemas.datacontract.org/2004/07/System.IO"><__identity i:nil="true" xmlns="http://schemas.datacontract.org/2004/07/System" /><_buffer></_buffer><_capacity>0</_capacity><_expandable>false</_expandable><_exposable>true</_exposable><_isOpen>true</_isOpen><_length>0</_length><_origin>0</_origin><_position>0</_position><_writable>true</_writable></MemoryStream>
Actual: <MemoryStream xmlns="http://schemas.datacontract.org/2004/07/System.IO" xmlns:i="http://www.w3.org/2001/XMLSchema-instance"><_buffer/><_capacity>0</_capacity><_expandable>false</_expandable><_exposable>true</_exposable><_isOpen>true</_isOpen><_length>0</_length><_origin>0</_origin><_position>0</_position><_writable>true</_writable></MemoryStream>
Expected: True
Actual:   False
CallStack
   at System.Runtime.Serialization.Tests.DataContractSerializerHelper.SerializeAndDeserialize[MemoryStream](MemoryStream value, String baseline, DataContractSerializerSettings settings, Func`1 serializerFactory, Boolean skipStringCompare, Boolean verifyBinaryRoundTrip)
   at DataContractSerializerTests.<DCS_MemoryStream_Serialize_UsesBuiltInAdapter>g__ValidateObject|240_0(MemoryStream original, String expectedXml, Byte[] expectedData, Int32 expectedPosition, Boolean expectedExposable)
   at DataContractSerializerTests.DCS_MemoryStream_Serialize_UsesBuiltInAdapter()
   at System.Reflection.MethodInvoker.InterpretedInvoke(Object , IntPtr* )
   at System.Reflection.MethodInvoker.Invoke(Object , IntPtr* , BindingFlags )

Was this helpful? Yes No