Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[test] Try to use nodejs instead of v8 #83524

Closed

Conversation

radekdoulik
Copy link
Member

No description provided.

@radekdoulik radekdoulik added the NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) label Mar 16, 2023
@ghost ghost assigned radekdoulik Mar 16, 2023
@ghost
Copy link

ghost commented Mar 16, 2023

Tagging subscribers to this area: @directhex
See info in area-owners.md if you want to be subscribed.

Issue Details

null

Author: radekdoulik
Assignees: radekdoulik
Labels:

NO-MERGE, area-Infrastructure-mono

Milestone: -

@radekdoulik
Copy link
Member Author

/azp run runtime-wasm

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@radekdoulik
Copy link
Member Author

/azp run runtime-wasm

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@pavelsavara
Copy link
Member

failed: Invalid opcode 0x06 (enable with --experimental-wasm-eh) @+87 Log

This is speculative jiterp, perhaps we could really enable EH.

[09:51:19] fail: [FAIL] System.Runtime.Intrinsics.Tests.Vectors.Vector64Tests.Vector64DoubleEqualsNaNTest
[09:51:19] info: Assert.True() Failure
[09:51:19] info: Expected: True
[09:51:19] info: Actual:   False
[09:51:19] info:    at System.Reflection.MethodInvoker.Invoke(Object , IntPtr* , BindingFlags )

Log

does this mean node doesn't have SIMD ? Or has bugs in it ? Or that's our implementation issue which was hidden till now ?

@radekdoulik
Copy link
Member Author

Might be actual issue, uncovered. I will look at it.

For EH, we talked about it with @lewing some time ago. I think we should enable it after p3 branches.

@radekdoulik
Copy link
Member Author

The DoubleEqualsNaNTest failure looks specific to that node version. It works fine locally on chrome, v8 and older node.

@radekdoulik
Copy link
Member Author

It is happening on main too, so something might changed recently. I will look again.

@ghost ghost closed this Apr 16, 2023
@ghost
Copy link

ghost commented Apr 16, 2023

Draft Pull Request was automatically closed for 30 days of inactivity. Please let us know if you'd like to reopen it.

@ghost
Copy link

ghost commented May 19, 2023

Draft Pull Request was automatically closed for 30 days of inactivity. Please let us know if you'd like to reopen it.

@ghost ghost locked as resolved and limited conversation to collaborators Jun 18, 2023
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-Infrastructure-mono NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants