Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[API Proposal]: Add overload for EventSource primitives #83751

Merged
merged 15 commits into from Jun 14, 2023
Merged

[API Proposal]: Add overload for EventSource primitives #83751

merged 15 commits into from Jun 14, 2023

Commits on Mar 30, 2023

  1. Add overload for EventSource primitives 

    I've seen a lot of calls to the varargs EventSource overload that have to manually
suppress the trim warning because they only use primitive types.

Adding this overload solves two problems:
  1. Users won't get a warning if their usage is safe.
  2. Users won't have to suppress a warning.
    @agocke
    agocke committed Mar 30, 2023
    Configuration menu
    Copy the full SHA
    058a46b View commit details
    Browse the repository at this point in the history

  2. Remove unused suppressions in MetricsEventSource

    @agocke
    agocke committed Mar 30, 2023
    Configuration menu
    Copy the full SHA
    dc1fef0 View commit details
    Browse the repository at this point in the history

  3. Add doc comments for EventSourcePrimitive

    @agocke
    agocke committed Mar 30, 2023
    Configuration menu
    Copy the full SHA
    6ad50d9 View commit details
    Browse the repository at this point in the history

  4. Remove suppressions from TransactionsEtwProvider

    @agocke
    agocke committed Mar 30, 2023
    Configuration menu
    Copy the full SHA
    6b0def3 View commit details
    Browse the repository at this point in the history

  5. Remove guidance around warning suppression, as the safe primitives sh… 

    …ould no longer produce warnings
    @agocke
    agocke committed Mar 30, 2023
    Configuration menu
    Copy the full SHA
    1a5101c View commit details
    Browse the repository at this point in the history

  6. Add tests

    @agocke
    agocke committed Mar 30, 2023
    Configuration menu
    Copy the full SHA
    b9d9e26 View commit details
    Browse the repository at this point in the history

  7. API compat suppressions

    @agocke
    agocke committed Mar 30, 2023
    Configuration menu
    Copy the full SHA
    2d79faa View commit details
    Browse the repository at this point in the history

  8. Add suppression for Mono

    @agocke
    agocke committed Mar 30, 2023
    Configuration menu
    Copy the full SHA
    9d0e720 View commit details
    Browse the repository at this point in the history

Commits on Apr 27, 2023

  1. Add remaining overloads as described in API review

    @agocke
    agocke committed Apr 27, 2023
    Configuration menu
    Copy the full SHA
    9457427 View commit details
    Browse the repository at this point in the history

Commits on May 19, 2023

  1. Merge remote-tracking branch 'upstream/main' into eventsource-overload

    @agocke
    agocke committed May 19, 2023
    Configuration menu
    Copy the full SHA
    e901cb1 View commit details
    Browse the repository at this point in the history

  2. Suppress warnings on TFMs < 8.0

    @agocke
    agocke committed May 19, 2023
    Configuration menu
    Copy the full SHA
    a46ea12 View commit details
    Browse the repository at this point in the history

  3. Add suppressions for System.Thread.Tasks.Dataflow

    @agocke
    agocke committed May 19, 2023
    Configuration menu
    Copy the full SHA
    004cc81 View commit details
    Browse the repository at this point in the history

  4. Remove suppressions

    @agocke
    agocke committed May 19, 2023
    Configuration menu
    Copy the full SHA
    561ca35 View commit details
    Browse the repository at this point in the history

Commits on Jun 9, 2023

  1. Merge remote-tracking branch 'upstream/main' into eventsource-overload

    @agocke
    agocke committed Jun 9, 2023
    Configuration menu
    Copy the full SHA
    cf6b458 View commit details
    Browse the repository at this point in the history

Commits on Jun 13, 2023

  1. Merge remote-tracking branch 'upstream/main' into eventsource-overload

    @agocke
    agocke committed Jun 13, 2023
    Configuration menu
    Copy the full SHA
    da088aa View commit details
    Browse the repository at this point in the history