Simplify numasupport #84207
Merged
Simplify numasupport #84207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
community-contribution
|
Tagging subscribers to this area: @hoyosjs Issue DetailsAimed to remove lib dependency.
|
am11
force-pushed
the
feature/native/deps
branch
from
de0ae6a
to
4a2a0ff
Compare
am11
force-pushed
the
feature/native/deps
branch
from
118e72b
to
420c0b8
Compare
jkotas
reviewed
Apr 1, 2023
jkotas
reviewed
Apr 1, 2023
am11
force-pushed
the
feature/native/deps
branch
from
29e60e1
to
af2144e
Compare
My main Linux devbox has NUMA enabled, so I can test it. |
janvorli
approved these changes
Apr 3, 2023
src/coreclr/gc/unix/numasupport.cpp
Outdated
| return; | ||
|
|
||
| g_numaAvailable = true; | ||
| g_highestNumaNode = GetNodeNum("/sys/devices/system/node", false); |
There was a problem hiding this comment.
The original (dynamic) code was disabling NUMA if there was just one NUMA node. In that case, it is useless to add complexities related to NUMA. I think we should do it here too.
This was referenced Apr 3, 2023
|
CI failures are known (according to Build Analysis). cc @jkotas, I'll update SDK tests (which counts the number of assets in |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aimed to remove lib dependency.