Use a tuned ConcurrentDictionary in the default caching implementation for the COM source generator #84335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ly performant thread-safe cache.
jkoritzinsky
added
area-System.Runtime.InteropServices
source-generator
jkoritzinsky
requested review from
AaronRobinsonMSFT,
jtschuster and
elinor-fung
ghost
assigned 
|
Tagging subscribers to this area: @dotnet/interop-contrib Issue DetailsUse a ConcurrentDictionary to ensure we have at least a simple decently performant thread-safe cache. Based on experience with CsWinRT, we'll try to tune this a little bit as we don't expect many concurrent writes to the cache.
|
This was referenced Apr 5, 2023
src/libraries/System.Runtime.InteropServices/tests/Ancillary.Interop/DefaultCaching.cs
Outdated
Show resolved
Hide resolved
AaronRobinsonMSFT
approved these changes
Apr 6, 2023
jtschuster
approved these changes
Apr 6, 2023
elinor-fung
approved these changes
Apr 6, 2023
|
All of the failures are known failures. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use a ConcurrentDictionary to ensure we have at least a simple decently performant thread-safe cache.
Based on experience with CsWinRT, we'll try to tune this a little bit as we don't expect many concurrent writes to the cache.