New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shrink hello world by 3.2% #84463
Shrink hello world by 3.2% #84463
Conversation
* Get rid of the MethodTable for double/float * Get rid of any `Array<T>` methods
Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas Issue Details
Cc @dotnet/ilc-contrib
|
@@ -43,15 +43,15 @@ static class NativeFormatEnumInfo | |||
var handle = field.DefaultValue; | |||
unsortedBoxedValues[i] = handle.HandleType switch | |||
{ | |||
HandleType.ConstantSByteValue => (byte)handle.ToConstantSByteValueHandle(reader).GetConstantSByteValue(reader).Value, | |||
HandleType.ConstantSByteValue => (object)(byte)handle.ToConstantSByteValueHandle(reader).GetConstantSByteValue(reader).Value, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was a fun headscratcher.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What was going on here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
type inference not cooperating
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup, things got widened to uint64 and then boxed as uint64. We need to box instead of widening.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
Array<T>
methodsCc @dotnet/ilc-contrib