Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow promotion of structs with single float fields #84627

Merged
merged 4 commits into from
Apr 12, 2023
Merged

Allow promotion of structs with single float fields #84627

merged 4 commits into from
Apr 12, 2023

Conversation

tannergooding
Copy link
Member

@tannergooding tannergooding commented Apr 11, 2023 •
edited
Loading

This resolves #79928

@dotnet-issue-labeler dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Apr 11, 2023
@ghost ghost assigned tannergooding Apr 11, 2023
@ghost
Copy link

ghost commented Apr 11, 2023

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch, @kunalspathak
See info in area-owners.md if you want to be subscribed.

Issue Details

null

Author: tannergooding
Assignees: tannergooding
Labels:

area-CodeGen-coreclr
Milestone: -

@tannergooding tannergooding marked this pull request as ready for review April 12, 2023 12:18
@tannergooding
Copy link
Member Author

CC. @dotnet/jit-contrib

@tannergooding
Copy link
Member Author

Diffs

Some good wins on all platforms, some much more than others depending on the ABI. A few small regressions where promotion ends up causing more codegen, but this is the same as with promotion for any other scenario as well.

jakobbotsch
jakobbotsch approved these changes Apr 12, 2023
View reviewed changes
Copy link
Member

@jakobbotsch jakobbotsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I think you should run some stress jobs.

@tannergooding
Copy link
Member Author

/azp run runtime-coreclr outerloop, runtime-coreclr jitstress, runtime-coreclr libraries-jitstress, Fuzzlyn

@azure-pipelines
Copy link

Azure Pipelines successfully started running 4 pipeline(s).

@EgorBo
Copy link
Member

EgorBo commented Apr 12, 2023 •
edited
Loading

is that the only github issue we have for floating-point-field promotion? I thought there were more 🙂

@tannergooding
Copy link
Member Author

I thought there were more

I did too, but GitHub search leaves a lot to be desired and I wasn't able to find them :(

@tannergooding
Copy link
Member Author

Logged the following for the two fuzzlyn failures:

For the JitStress failures:

@tannergooding
Copy link
Member Author

Outerloop failures are also failing in main.

@tannergooding tannergooding merged commit ebe11ca into dotnet:main Apr 12, 2023
@tannergooding tannergooding deleted the promote-single-float branch April 12, 2023 19:13
@EgorBo EgorBo mentioned this pull request Apr 20, 2023
Closed
@ghost ghost locked as resolved and limited conversation to collaborators May 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jakobbotsch jakobbotsch jakobbotsch approved these changes

Assignees

@tannergooding tannergooding

Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unused struct fields sometimes improve the codegen
3 participants
@tannergooding @EgorBo @jakobbotsch