Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SPMI: Add possibility to specify custom options in diffs pipeline #84645

Merged
merged 1 commit into from Apr 12, 2023

Conversation

jakobbotsch
Copy link
Member

Allow specifying jit options on manual triggers of superpmi-diffs. I want to use this to look at diffs with future changes in physical promotion given that it is still disabled by default.

Allow specifying jit options on manual triggers of superpmi-diffs. I
want to use this to look at diffs with future changes in physical
promotion given that it is still disabled by default.
@ghost ghost assigned jakobbotsch Apr 11, 2023
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Apr 11, 2023
@ghost
Copy link

ghost commented Apr 11, 2023

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch, @kunalspathak
See info in area-owners.md if you want to be subscribed.

Issue Details

Allow specifying jit options on manual triggers of superpmi-diffs. I want to use this to look at diffs with future changes in physical promotion given that it is still disabled by default.

Author: jakobbotsch
Assignees: jakobbotsch
Labels:

area-CodeGen-coreclr

Milestone: -

@jakobbotsch jakobbotsch marked this pull request as ready for review April 11, 2023 21:10
@jakobbotsch
Copy link
Member Author

Example run with JitStressModeNames=STRESS_PHYSICAL_PROMOTION: https://dev.azure.com/dnceng-public/public/_build/results?buildId=235082&view=ms.vss-build-web.run-extensions-tab

Triggered like this:
image

The superpmi-diffs failures are the current known ones.

cc @dotnet/jit-contrib PTAL @BruceForstall

Copy link
Member

@BruceForstall BruceForstall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool! I had no idea parameters was an AzDO Pipelines feature.

@jakobbotsch jakobbotsch merged commit 1cc5afb into dotnet:main Apr 12, 2023
174 of 178 checks passed
@jakobbotsch jakobbotsch deleted the superpmi-diffs-env-vars branch April 12, 2023 11:19
@ghost ghost locked as resolved and limited conversation to collaborators May 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants