Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add binary parsing support to integer types #84998

Merged
merged 3 commits into from Apr 19, 2023
Merged

Add binary parsing support to integer types #84998

merged 3 commits into from Apr 19, 2023

Conversation

stephentoub
Copy link
Member

Contributes to #83619

@dotnet-issue-labeler dotnet-issue-labeler bot added needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners new-api-needs-documentation labels Apr 18, 2023
@dotnet-issue-labeler
Copy link

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@ghost ghost assigned stephentoub Apr 18, 2023
@stephentoub stephentoub mentioned this pull request Apr 18, 2023
Closed
tannergooding
tannergooding reviewed Apr 18, 2023
View reviewed changes
src/libraries/System.Private.CoreLib/src/System/Number.Parsing.cs
public static TInteger ShiftLeftForNextDigit(TInteger value) => TInteger.MultiplyBy16(value);
}

private readonly struct BinaryParser<TInteger> : IHexOrBinaryParser<TInteger> where TInteger : unmanaged, IBinaryIntegerParseAndFormatInfo<TInteger>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if its worth optimizing for processing multiple bits at a time. Doing up to 64-iterations for -1L is a lot for example.

-- Not something that needs to be in this PR, but might be worth an up-for-grabs issue if anyone is interested in optimizing it further.

@tannergooding
Copy link
Member

Seems the tests in

runtime/src/libraries/System.Globalization/tests/NumberFormatInfo/NumberFormatInfoValidateParseStyle.cs

Line 32 in 9cc8163

public void ValidateParseStyle_Float(NumberStyles style, bool valid, string paramName)

are unhappy and surprisingly its not the one that's checking unchecked((NumberStyles)0xFFFFFC00) is not valid...

@stephentoub
Copy link
Member Author

Thanks. Yeah, it doesn't like that I added a parameter name to the exception (it's upset the name isn't null) . Will fix the test.

This was referenced Apr 19, 2023
Closed
Closed
Closed
This was referenced Apr 19, 2023
Closed
Closed
@stephentoub stephentoub merged commit 494bbc8 into dotnet:main Apr 19, 2023
164 of 167 checks passed
@stephentoub stephentoub deleted the binaryparsing branch April 19, 2023 09:58
@tannergooding tannergooding mentioned this pull request Apr 20, 2023
Open
@kunalspathak kunalspathak mentioned this pull request Apr 25, 2023
Closed
@dotnet dotnet locked as resolved and limited conversation to collaborators May 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tannergooding tannergooding tannergooding approved these changes

Assignees

@stephentoub stephentoub

Labels
needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners new-api-needs-documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@stephentoub @tannergooding