Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use CollectionsMarshal.SetCount in LINQ to deduplicate ToArray/ToList implementations #85288

Merged
merged 2 commits into from Apr 25, 2023
Merged

Use CollectionsMarshal.SetCount in LINQ to deduplicate ToArray/ToList implementations #85288

merged 2 commits into from Apr 25, 2023

Conversation

stephentoub
Copy link
Member

No description provided.

@ghost ghost assigned stephentoub Apr 25, 2023
@ghost
Copy link

ghost commented Apr 25, 2023

Tagging subscribers to this area: @dotnet/area-system-linq
See info in area-owners.md if you want to be subscribed.

Issue Details

null

Author: stephentoub
Assignees: -
Labels:

area-System.Linq
Milestone: -

@build-analysis build-analysis bot mentioned this pull request Apr 25, 2023
Closed
eiriktsarpalis
eiriktsarpalis approved these changes Apr 25, 2023
View reviewed changes
Copy link
Member

@eiriktsarpalis eiriktsarpalis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@build-analysis build-analysis bot mentioned this pull request Apr 25, 2023
Closed
@stephentoub
Fix BinaryFormatter test
b74f630 
The test was implemented using ToList, and `List<T>` serialization serializes out its version field.  As a result, because we're now optimizing creation and not incrementing the version as much in ToList, the blob didn't match.
@stephentoub stephentoub merged commit b42626f into dotnet:main Apr 25, 2023
107 of 113 checks passed
@stephentoub stephentoub deleted the linqsetcount branch April 25, 2023 20:05
@build-analysis build-analysis bot mentioned this pull request Apr 26, 2023
Closed
@cincuranet cincuranet mentioned this pull request May 4, 2023
Closed
This was referenced May 4, 2023
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
@dotnet dotnet locked as resolved and limited conversation to collaborators May 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@eiriktsarpalis eiriktsarpalis eiriktsarpalis approved these changes

Assignees

@stephentoub stephentoub

Labels
area-System.Linq
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@stephentoub @eiriktsarpalis