Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get rid of reflection blocked types #85810

Merged
merged 6 commits into from
May 8, 2023

Commits on May 5, 2023

  1. Get rid of reflection blocked types

    Fixes dotnet#72570.
    
    Still need to delete workarounds that make things public in corelib but maybe this diff is large enough already?
    
    We were gradually getting less and less from reflection blocking:
    
    * We stopped blocking things outside corelib (.NET Native blocked all of BCL; we don't).
    * We trim reflection metadata and that allows us to have method bodies without metadata.
    
    With this, we should be able to get type definition-level reflection metadata for any MethodTable there is in the system.
    
    This is a ~30 kB size regression for BasicMinimalApis. It is pretty much a wash for Hello World, because all the BCL cruft to handle reflection blocked types costs as much as the benefit of blocking.
    MichalStrehovsky committed May 5, 2023
    Configuration menu
    Copy the full SHA
    f70486b View commit details
    Browse the repository at this point in the history
  2. Fix release builds

    MichalStrehovsky committed May 5, 2023
    Configuration menu
    Copy the full SHA
    6f8c84f View commit details
    Browse the repository at this point in the history

Commits on May 8, 2023

  1. Configuration menu
    Copy the full SHA
    1b4915f View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    a7a7251 View commit details
    Browse the repository at this point in the history
  3. Update src/libraries/System.Private.CoreLib/src/System/Text/Latin1Enc…

    …oding.cs
    
    Co-authored-by: Jan Kotas <jkotas@microsoft.com>
    MichalStrehovsky and jkotas committed May 8, 2023
    Configuration menu
    Copy the full SHA
    8c2c5ee View commit details
    Browse the repository at this point in the history
  4. Update src/libraries/System.Private.CoreLib/src/System/Text/Latin1Enc…

    …oding.cs
    
    Co-authored-by: Jan Kotas <jkotas@microsoft.com>
    MichalStrehovsky and jkotas committed May 8, 2023
    Configuration menu
    Copy the full SHA
    5cfb256 View commit details
    Browse the repository at this point in the history