Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ToDictionary() overloads for KeyValuePair and ValueTuple kv. #85811

Merged
merged 4 commits into from May 17, 2023
Merged

Add ToDictionary() overloads for KeyValuePair and ValueTuple kv. #85811

merged 4 commits into from May 17, 2023

Conversation

lateapexearlyspeed
Copy link
Contributor

@lateapexearlyspeed lateapexearlyspeed commented May 5, 2023 •
edited

Fix #65925

@dotnet-issue-labeler
Copy link

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label May 5, 2023
@ghost
Copy link

ghost commented May 5, 2023

Tagging subscribers to this area: @dotnet/area-system-collections
See info in area-owners.md if you want to be subscribed.

Issue Details

Fix #65925
In development and will mark it as ready for review when ready, thanks !

Author: lateapexearlyspeed
Assignees: -
Labels:

area-System.Collections, new-api-needs-documentation
Milestone: -

@lateapexearlyspeed lateapexearlyspeed marked this pull request as ready for review May 8, 2023 08:14
@lateapexearlyspeed lateapexearlyspeed mentioned this pull request May 8, 2023
Closed
@lateapexearlyspeed
Fix comments: use Dictionary's ctor for IEnumerable<KeyValuePair<>> o…
c5038db 
…verload; API signature changed to nullable comparer.
@build-analysis build-analysis bot mentioned this pull request May 16, 2023
Closed
@stephentoub
Copy link
Member

Thanks!

@stephentoub stephentoub merged commit 95c83fc into dotnet:main May 17, 2023
105 checks passed
@TonyValenti
Copy link

Can you also add this for .ToImmutableDictionary()?

@stephentoub
Copy link
Member

Please open an issue.

@viceroypenguin viceroypenguin mentioned this pull request May 22, 2023
Closed
@dotnet dotnet locked as resolved and limited conversation to collaborators Jun 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@saul saul saul left review comments

@huoyaoyuan huoyaoyuan huoyaoyuan left review comments

@stephentoub stephentoub stephentoub approved these changes

Assignees

@krwq krwq

Labels
area-System.Collections community-contribution Indicates that the PR has been added by a community member new-api-needs-documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[API Proposal]: Add overload of ToDictionary that turns an IEnumerable of KeyValuePair or ValueTuple
6 participants
@lateapexearlyspeed @stephentoub @TonyValenti @saul @huoyaoyuan @krwq