avoid ProtocolToken allocations in TLS handshake #86163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @dotnet/ncl, @bartonjs, @vcsjones Issue DetailsProtocolToken are somewhat high for 1000 TLS handshakes: Since that is basically just container for status and buffet it seems unnecessary. There may be further optimizations but for now I turn it into AFAIK this is last low hanging fruit -> closes #68951
|
MihaZupan
approved these changes
May 12, 2023
| @@ -31,13 +31,13 @@ private JavaProxy.RemoteCertificateValidationResult VerifyRemoteCertificate() | |||
| }; | |||
| } | |||
|
|
|||
| private bool TryGetRemoteCertificateValidationResult(out SslPolicyErrors sslPolicyErrors, out X509ChainStatusFlags chainStatus, out ProtocolToken? alertToken, out bool isValid) | |||
| private bool TryGetRemoteCertificateValidationResult(out SslPolicyErrors sslPolicyErrors, out X509ChainStatusFlags chainStatus, ref ProtocolToken alertToken, out bool isValid) | |||
There was a problem hiding this comment.
Nit: A bunch of these look like they could remain as out (e.g., NextMessage, ProcessTlsFrame)
stephentoub
approved these changes
May 15, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ProtocolToken are somewhat high for 1000 TLS handshakes:
Since that is basically just container for status and buffet it seems unnecessary. There may be further optimizations but for now I turn it into
structand pass ref to it. To pass that across async boundaryReceiveBlobAsyncno longer calls crypto e.g. it does only IO andProcessTlsFrame(former ProcessBlob) is called explicit to process it.AFAIK this is last low hanging fruit -> closes #68951