Initial build configuration for Haiku #86303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
community-contribution
|
Tagging subscribers to this area: @dotnet/area-infrastructure-libraries Issue DetailsAdd support for Haiku build configuration files in Part of #55803.
|
ViktorHofer
reviewed
May 16, 2023
|
Tagging subscribers to this area: @dotnet/runtime-infrastructure Issue DetailsAdd support for Haiku in build configuration files in Part of #55803.
|
am11
reviewed
May 16, 2023
jkotas
reviewed
May 16, 2023
| @@ -214,6 +214,12 @@ if(CLR_CMAKE_HOST_OS STREQUAL sunos) | |||
| endif(SUNOS_KERNEL_KIND STREQUAL illumos OR CMAKE_CROSSCOMPILING) | |||
| endif(CLR_CMAKE_HOST_OS STREQUAL sunos) | |||
|
|
|||
| if(CLR_CMAKE_HOST_OS STREQUAL haiku) | |||
| set(CLR_CMAKE_HOST_UNIX 1) | |||
| set(CLR_CMAKE_HOST_UNIX_AMD64 1) | |||
There was a problem hiding this comment.
Does Haiku support building on x64 host only?
There was a problem hiding this comment.
For the purpose of this PR and the ones by me in the near future, yes.
jkotas
reviewed
May 16, 2023
jkotas
reviewed
May 16, 2023
Initially recognize Haiku as a supported platform in Directory.Build.props and all scripts in eng/**.
trungnt2910
force-pushed
the
dev/trungnt2910/haiku-eng
branch
3 times, most recently
from
8b2c462
to
d5b5866
Compare
Drop some unused configure values from tryrun.cmake, configure.cmake and config.h.in.
Simplified an error message for the `--os` option to avoid maintaining a duplicate list of OSes. Co-authored-by: Adeel Mujahid <3840695+am11@users.noreply.github.com>
trungnt2910
force-pushed
the
dev/trungnt2910/haiku-eng
branch
from
d5b5866
to
4c1fbea
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for Haiku in build configuration files in
eng/native/**Part of #55803.