Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[mono][wasm] Fix support for virtual invokes. #86687

Merged
merged 1 commit into from
May 24, 2023
Merged

[mono][wasm] Fix support for virtual invokes. #86687

merged 1 commit into from
May 24, 2023

Conversation

vargaz
Copy link
Contributor

@vargaz vargaz commented May 24, 2023

Fixes #86621.

@vargaz vargaz requested a review from LeVladIonescu May 24, 2023 05:35
@vargaz
Copy link
Contributor Author

vargaz commented May 24, 2023

/azp runtime-wasm

@azure-pipelines
Copy link

Command 'runtime-wasm' is not supported by Azure Pipelines.

Supported commands
  • help:
    • Get descriptions, examples and documentation about supported commands
    • Example: help "command_name"
  • list:
    • List all pipelines for this repository using a comment.
    • Example: "list"
  • run:
    • Run all pipelines or specific pipelines for this repository using a comment. Use this command by itself to trigger all related pipelines, or specify specific pipelines to run.
    • Example: "run" or "run pipeline_name, pipeline_name, pipeline_name"
  • where:
    • Report back the Azure DevOps orgs that are related to this repository and org
    • Example: "where"

See additional documentation.

@vargaz
Copy link
Contributor Author

vargaz commented May 24, 2023

/azp run runtime-wasm

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ghost ghost assigned vargaz May 24, 2023
@vargaz vargaz merged commit 5510775 into dotnet:main May 24, 2023
107 of 113 checks passed
@vargaz vargaz deleted the wasm-invoke-callvirt branch May 24, 2023 08:20
@lewing
Copy link
Member

lewing commented May 24, 2023

/backport to release/8.0-preview5

@github-actions
Copy link
Contributor

Started backporting to release/8.0-preview5: https://github.com/dotnet/runtime/actions/runs/5069599176

@github-actions github-actions bot mentioned this pull request May 24, 2023
Merged
@ghost ghost locked as resolved and limited conversation to collaborators Jun 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@LeVladIonescu LeVladIonescu LeVladIonescu approved these changes

@lambdageek lambdageek Awaiting requested review from lambdageek lambdageek is a code owner

@SamMonoRT SamMonoRT Awaiting requested review from SamMonoRT

Assignees

@vargaz vargaz

Labels
area-Codegen-JIT-mono
Projects
None yet
Milestone
No milestone
3 participants
@vargaz @lewing @LeVladIonescu