New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CoreCLR/NativeAOT] `UnsafeAccessorAttribute` non-generic support #86932

Merged

AaronRobinsonMSFT merged 55 commits into dotnet:main from AaronRobinsonMSFT:runtime_86161

Jun 15, 2023

Member

AaronRobinsonMSFT commented May 31, 2023

Contributes to #86161

AaronRobinsonMSFT added the area-VM-coreclr label

AaronRobinsonMSFT added this to the 8.0.0 milestone

AaronRobinsonMSFT requested a review from jkotas

May 31, 2023 04:04

dotnet-issue-labeler bot added the new-api-needs-documentation label

dotnet-issue-labeler bot commented May 31, 2023

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

ghost assigned AaronRobinsonMSFT

Member Author

AaronRobinsonMSFT commented May 31, 2023 •

edited

Loading

/cc @lambdageek @fanyang-mono @roji

AaronRobinsonMSFT mentioned this pull request

[CoreCLR] Implement support for UnsafeAccessorAttribute #86161

Closed

6 tasks

AaronRobinsonMSFT commented

View reviewed changes

src/coreclr/vm/methodtablebuilder.h Outdated Show resolved Hide resolved

jkotas reviewed

View reviewed changes

src/coreclr/vm/dynamicmethod.h Outdated Show resolved Hide resolved

jkotas reviewed

View reviewed changes

src/coreclr/vm/prestub.cpp Outdated Show resolved Hide resolved

This was referenced May 31, 2023

Tracking issue for CI build timeouts #76454

Closed

Failed USB connection via port 54050, error 61, in tvOS arm64 Release AllSubsets_Mono #82637

Open

This was referenced May 31, 2023

Infra improvements for Helix #68176

Closed

Methodical_others test JIT/Methodical/Coverage/copy_prop_byref_to_native_int crashing #69832

Open

Long Running Test: Interop/MonoAPI/MonoMono/PInvokeDetach/PInvokeDetach.sh #73040

Closed

jkotas reviewed

View reviewed changes

src/coreclr/vm/dynamicmethod.cpp Outdated Show resolved Hide resolved

jkotas reviewed

View reviewed changes

src/coreclr/vm/jitinterface.cpp Outdated Show resolved Hide resolved

IDisposable reviewed

View reviewed changes

src/coreclr/inc/sarray.h Show resolved Hide resolved

IDisposable reviewed

View reviewed changes

src/coreclr/vm/dynamicmethod.h Outdated Show resolved Hide resolved

src/coreclr/vm/dynamicmethod.cpp Outdated Show resolved Hide resolved

build-analysis bot mentioned this pull request

Could not load file or assembly 'Microsoft.CodeAnalysis.NetAnalyzers #84995

Closed

AaronRobinsonMSFT commented

View reviewed changes

...raries/System.Private.CoreLib/src/System/Runtime/CompilerServices/UnsafeAccessorAttribute.cs Show resolved Hide resolved

AaronRobinsonMSFT marked this pull request as ready for review

May 31, 2023 20:51

IDisposable reviewed

View reviewed changes

src/coreclr/vm/methodtablebuilder.h Show resolved Hide resolved

IDisposable reviewed

View reviewed changes

src/coreclr/vm/jitinterface.cpp Show resolved Hide resolved

build-analysis bot mentioned this pull request

Timeout in System.Net.Quic.Functional.Tests #86019

Closed

stephentoub reviewed

View reviewed changes

...raries/System.Private.CoreLib/src/System/Runtime/CompilerServices/UnsafeAccessorAttribute.cs Outdated Show resolved Hide resolved

...raries/System.Private.CoreLib/src/System/Runtime/CompilerServices/UnsafeAccessorAttribute.cs Outdated Show resolved Hide resolved

...raries/System.Private.CoreLib/src/System/Runtime/CompilerServices/UnsafeAccessorAttribute.cs Outdated Show resolved Hide resolved

...raries/System.Private.CoreLib/src/System/Runtime/CompilerServices/UnsafeAccessorAttribute.cs Outdated Show resolved Hide resolved

...raries/System.Private.CoreLib/src/System/Runtime/CompilerServices/UnsafeAccessorAttribute.cs

    
                      /// <summary>

                      /// Provide access to a Method.

                      /// </summary>

                      Method,

Member

stephentoub Jun 1, 2023

Is this any method or just instance method? The naming is strange if it's the latter.

Member Author

AaronRobinsonMSFT Jun 1, 2023

It is for an instance method. That is what API decided upon. I can go back and ask if you think InstanceMethod is more appropriate?

...raries/System.Private.CoreLib/src/System/Runtime/CompilerServices/UnsafeAccessorAttribute.cs Outdated Show resolved Hide resolved

...raries/System.Private.CoreLib/src/System/Runtime/CompilerServices/UnsafeAccessorAttribute.cs Outdated Show resolved Hide resolved

...raries/System.Private.CoreLib/src/System/Runtime/CompilerServices/UnsafeAccessorAttribute.cs Outdated Show resolved Hide resolved

...raries/System.Private.CoreLib/src/System/Runtime/CompilerServices/UnsafeAccessorAttribute.cs Outdated Show resolved Hide resolved

...raries/System.Private.CoreLib/src/System/Runtime/CompilerServices/UnsafeAccessorAttribute.cs Show resolved Hide resolved

IDisposable reviewed

View reviewed changes

Contributor

IDisposable left a comment

So reminiscent of the old days ...

...raries/System.Private.CoreLib/src/System/Runtime/CompilerServices/UnsafeAccessorAttribute.cs Outdated Show resolved Hide resolved

jkotas reviewed

View reviewed changes

src/coreclr/vm/dynamicmethod.h Outdated Show resolved Hide resolved

src/coreclr/vm/jitinterface.cpp Show resolved Hide resolved

src/coreclr/vm/prestub.cpp Outdated Show resolved Hide resolved

src/coreclr/vm/prestub.cpp Outdated Show resolved Hide resolved

src/coreclr/vm/prestub.cpp Outdated Show resolved Hide resolved

src/coreclr/vm/prestub.cpp Outdated Show resolved Hide resolved

src/coreclr/vm/prestub.cpp Outdated Show resolved Hide resolved

IDisposable reviewed

View reviewed changes

...raries/System.Private.CoreLib/src/System/Runtime/CompilerServices/UnsafeAccessorAttribute.cs Outdated Show resolved Hide resolved

azure-pipelines bot commented Jun 9, 2023

Azure Pipelines successfully started running 1 pipeline(s).


          NativeAOT error handling was throwing asserts.

d3b0726

jkotas reviewed

View reviewed changes

src/coreclr/tools/Common/TypeSystem/IL/UnsafeAccessors.cs Outdated Show resolved Hide resolved

AaronRobinsonMSFT added 2 commits

June 9, 2023 20:24


          Remove catch all for any exception. This code

56d733e

path has evolved to require exceptions to
propagate for generation of typeload exception
stub.


          Use declaration method as owner for stubs

facc48e

jkotas reviewed

View reviewed changes

src/coreclr/vm/siginfo.hpp Outdated Show resolved Hide resolved

jkotas reviewed

View reviewed changes

src/coreclr/tools/Common/TypeSystem/IL/UnsafeAccessors.cs Show resolved Hide resolved

jkotas reviewed

View reviewed changes

src/coreclr/tools/Common/TypeSystem/IL/UnsafeAccessors.cs Outdated Show resolved Hide resolved


          Review feedback

8d92e7e

jkotas reviewed

View reviewed changes

src/coreclr/vm/memberload.h Show resolved Hide resolved

AaronRobinsonMSFT added 5 commits

June 12, 2023 08:07


          Improve MissingMethodException

b446a20

Add test for validation


          Missed fallback name lookup on NativeAOT.

5b67d04

Added tests for pointer types and declaration name
lookup.


          Tests for calling convention bits on NativeAOT.

3663bad


          Remove block of doc text for generics. Will add

c2be6fc

back when supported is added.


          Treat signature calling convention bits like we treat

63f975c

custom modifiers during method lookup.

MichalStrehovsky reviewed

View reviewed changes

src/coreclr/tools/Common/TypeSystem/IL/UnsafeAccessors.cs Outdated Show resolved Hide resolved

jkotas reviewed

View reviewed changes

src/coreclr/vm/siginfo.cpp Outdated Show resolved Hide resolved

AaronRobinsonMSFT added 2 commits

June 13, 2023 14:35


          Managed and unmanaged function pointers never

869a5f0

signature match.


          Feedback for throwing exceptions on NativeAOT

c03dc9e

Remove unmanage resource string and move it to SPCL
Share the AmbiguousMatchException message between
  NativeAOT and CoreCLR.

build-analysis bot mentioned this pull request

Unable to load Analyzer assembly .../Microsoft.CodeAnalysis.Analyzers.dll : Not a valid assembly #85082

Closed

jkotas approved these changes

View reviewed changes

Member

jkotas left a comment

LGTM. Thank you for your work on this feature!

AaronRobinsonMSFT added 2 commits

June 14, 2023 06:12


          Merge remote-tracking branch 'upstream/main' into runtime_86161

a309b06


          Missing NAOT version of error string

b957416

Member Author

AaronRobinsonMSFT commented Jun 14, 2023

@MichalStrehovsky Can you take another look at the NativeAOT portions? I'd like a sign off from you too with respect to how this is implemented there.

IDisposable reviewed

View reviewed changes

src/coreclr/vm/method.hpp Outdated Show resolved Hide resolved

MichalStrehovsky approved these changes

View reviewed changes

Member

MichalStrehovsky left a comment

Thank you!

AaronRobinsonMSFT merged commit 5649739 into dotnet:main

167 of 171 checks passed

AaronRobinsonMSFT deleted the runtime_86161 branch

June 15, 2023 13:59

AaronRobinsonMSFT changed the title ~~[CoreCLR] UnsafeAccessorAttribute non-generic support~~ [CoreCLR/NativeAOT] UnsafeAccessorAttribute non-generic support

ghost locked as resolved and limited conversation to collaborators

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

IDisposable IDisposable left review comments

stephentoub stephentoub left review comments

DaZombieKiller DaZombieKiller left review comments

vitek-karas vitek-karas left review comments

hamarb123 hamarb123 left review comments

jkotas jkotas approved these changes

MichalStrehovsky MichalStrehovsky approved these changes