Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RISC-V] Sync comment and implementation #87033

Merged
merged 1 commit into from Jun 3, 2023
Merged

[RISC-V] Sync comment and implementation #87033

merged 1 commit into from Jun 3, 2023

Conversation

wscho77
Copy link
Contributor

@wscho77 wscho77 commented Jun 1, 2023

To remove misunderstanding, sync comment and implementation.

@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Jun 1, 2023
@clamp03 clamp03 added the arch-riscv Related to the RISC-V architecture label Jun 2, 2023
clamp03
clamp03 approved these changes Jun 2, 2023
View reviewed changes
Copy link
Member

@clamp03 clamp03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much.

@clamp03
Copy link
Member

clamp03 commented Jun 3, 2023

@jkotas Could you review this PR and merge? I checked the comments and the implementations are synced well in the PR. Thank you.

jkotas
jkotas approved these changes Jun 3, 2023
View reviewed changes
Copy link
Member

@jkotas jkotas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@jkotas jkotas merged commit 2f18320 into dotnet:main Jun 3, 2023
109 checks passed
@ghost ghost locked as resolved and limited conversation to collaborators Jul 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@clamp03 clamp03 clamp03 approved these changes

@jkotas jkotas jkotas approved these changes

Assignees

@wscho77 wscho77

Labels
arch-riscv Related to the RISC-V architecture area-VM-coreclr community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@wscho77 @clamp03 @jkotas