Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add UncodeJsonEncoder (fixes #42847). #87147

Conversation

davidmatson
Copy link

Also fixes #86800.
Also fixes #87138 (except docs outside this repo).

@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Jun 5, 2023
@ghost
Copy link

ghost commented Jun 5, 2023

Tagging subscribers to this area: @dotnet/area-system-text-encodings-web
See info in area-owners.md if you want to be subscribed.

Issue Details

Also fixes #86800.
Also fixes #87138 (except docs outside this repo).

Author: davidmatson
Assignees: -
Labels:

area-System.Text.Encodings.Web

Milestone: -

@davidmatson
Copy link
Author

This is just the product code part, not tests; I intentionally omitted those for now to focus the discussion on the product code side first.

@eiriktsarpalis
Copy link
Member

The API shape seems consistent with what we might be looking for in #42847. Before we can entertain an implementation this would need to go through API review. TL;DR an issue with an API proposal needs to be brought in for review. Going forward I would recommend contributing to an API proposal in #42847 and we can try bringing it in for review.

In the meantime, is it ok if you could convert this PR to a draft? We're tracking time-to-merge metrics for open PRs and it's unlikely this would get merged anytime soon..

@davidmatson
Copy link
Author

@eiriktsarpalis I looked around for a button to convert to draft, but I don't see one. Feel free to click it if it shows up for you.

@davidmatson
Copy link
Author

FYI - I opened an API proposal as well (#87153).

Also fixes dotnet#86800.
Also fixes dotnet#87138 (except docs outside this repo).
@davidmatson davidmatson force-pushed the user/davidmatson/unicodeJsonEncoder branch from 5dc851e to 04fe35e Compare June 5, 2023 22:30
@ghost ghost closed this Jul 5, 2023
@ghost
Copy link

ghost commented Jul 5, 2023

Draft Pull Request was automatically closed for 30 days of inactivity. Please let us know if you'd like to reopen it.

@ghost ghost locked as resolved and limited conversation to collaborators Aug 5, 2023
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-System.Text.Encodings.Web community-contribution Indicates that the PR has been added by a community member
Projects
None yet
2 participants