New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix parameter ordering and value in gtNewColonNode #87366
Conversation
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch Issue DetailsTo match the constructor parameters of All of the callers are passing arguments in the correct order. The 64 bit BSR implementation of LZCNT gets an int colon instead of long. Since the result is <64, there wasn't incorrect truncation if JIT is tolerate to such type mismatch.
|
Does this fix a bug or something? The problem that ElseNode is op1 so it just adds more confusion where we already have it. A proper fix might require more changes runtime/src/coreclr/jit/gentree.h Lines 3956 to 3970 in 66def3a
(see comment) cc @dotnet/jit-contrib |
This fixes my confusion when trying to use runtime/src/coreclr/jit/gentree.h Lines 3978 to 3980 in 66def3a
The parameter names in GenTreeColon constructor are correct, but |
To match the constructor parameters of
GenTreeColon
.All of the callers are passing arguments in the correct order. The 64 bit BSR implementation of LZCNT gets an int colon instead of long. Since the result is <64, there wasn't incorrect truncation if JIT is tolerate to such type mismatch.