Additional JsonNode functionality

[RaymondHuy]

Resolve #56592

[dotnet-issue-labeler]

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

[ghost]

Tagging subscribers to this area: @dotnet/area-system-text-json, @gregsdennis
See info in area-owners.md if you want to be subscribed.

Issue Details

---

Resolve #56592

Author:	RaymondHuy
Assignees:	-
Labels:	area-System.Text.Json, new-api-needs-documentation
Milestone:	-

[RaymondHuy]

Hi @eiriktsarpalis @layomia could you help me review this PR ?

[eiriktsarpalis]

This does not account for escaped strings when you have JsonValueKind.String

[RaymondHuy]

Hi @eiriktsarpalis I can get this test passed:
`

    [Fact]
    public static void DeepEquals_EscapedString()
    {
        JsonValue jsonValue = JsonValue.Create(JsonDocument.Parse("\"It\'s alright\"").RootElement);
        JsonValue escapedJsonValue = JsonValue.Create(JsonDocument.Parse("\"It\u0027s alright\"").RootElement);
        Assert.True(JsonNode.DeepEquals(escapedJsonValue, jsonValue));
    }

`
or maybe I misunderstand your meaning, could you give me an example test case for it ?

[eiriktsarpalis]

That's what I meant. I'm actually surprised that the test is passing, so I would guess that GetRawValue() actually does unescaping. In any case, I think it might make sense to call ValueEquals specifically when you have string value kinds (since IIRC that kind is supported by that method.

[eiriktsarpalis]

At the same time you could call GetBoolean() for the case of True/False.

[RaymondHuy]

thanks @eiriktsarpalis , I have updated it and added test case for escaped string case.

[eiriktsarpalis]

At the same time you could call GetBoolean() for the case of True/False.

Actually, wondering if just comparing with jsonElementNodeOther.ValueKind should suffice in this case:

                        case JsonValueKind.True:
                        case JsonValueKind.False:
                            return jsonElementCurrent.ValueKind == jsonElementNodeOther.ValueKind;

[eiriktsarpalis]

This looks great. If you could address the final test feedback I can merge this. 🎉

[gregsdennis]

Thanks @RaymondHuy and @eiriktsarpalis! This covers a lot of the functionality I have in Json.More.Net!