Subject src-gen serializer to full number-handling test #87484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
|
Tagging subscribers to this area: @dotnet/area-system-text-json, @gregsdennis |
layomia
approved these changes
Jun 13, 2023
| @@ -104,8 +109,7 @@ public bool IsFastPathSupported() | |||
| foreach (PropertyGenerationSpec property in PropertyGenSpecs) | |||
| { | |||
| if (property.PropertyType.SpecialType is SpecialType.System_Object || | |||
| property.NumberHandling is JsonNumberHandling.AllowNamedFloatingPointLiterals | |||
| or JsonNumberHandling.WriteAsString || | |||
| property.NumberHandling != null || | |||
There was a problem hiding this comment.
Should the same check for type infos apply here?
There was a problem hiding this comment.
It's causing test failures for cases where you have properties containing POCOs annotated with JsonNumberHandling.Strict and you have global configuration specifying WriteAsString. The fast-path method cannot pass the property-level configuration to downlevel JsonSerializer.Serialize calls so it ends up picking up the global configuration incorrectly. Probably not a super common scenario but I figured we should be conservative for now.
3 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revives #78010
Fixes #58638. Fixes #79511. Contributes to #73714.