Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add support for https proxy #87638

Merged
merged 5 commits into from Jun 22, 2023
Merged

add support for https proxy #87638

merged 5 commits into from Jun 22, 2023

Conversation

wfurt
Copy link
Member

@wfurt wfurt commented Jun 15, 2023

fixes #31113 .
I could not find functional public proxy for testing. Plain HTTP is no brainer, HTTPS over HTTPS is somewhat more complicated and I'll ask community for validation.

@wfurt wfurt added this to the 8.0.0 milestone Jun 15, 2023
@wfurt wfurt requested a review from a team June 15, 2023 19:41
@wfurt wfurt self-assigned this Jun 15, 2023
@ghost
Copy link

ghost commented Jun 15, 2023

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

fixes #31113 .
I could not find functional public proxy for testing. Plain HTTP is no brainer, HTTPS over HTTPS is somewhat more complicated and I'll ask community for validation.

Author: wfurt
Assignees: wfurt
Labels:

area-System.Net.Http
Milestone: 8.0.0

@build-analysis build-analysis bot mentioned this pull request Jun 15, 2023
Closed
stephentoub
stephentoub approved these changes Jun 16, 2023
View reviewed changes
Copy link
Member

@stephentoub stephentoub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@wfurt
Copy link
Member Author

wfurt commented Jun 16, 2023

failures may be relevant. Investigating..

@antonfirsov
Copy link
Member

/azp run runtime-libraries-coreclr outerloop

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@antonfirsov
Copy link
Member

/azp run runtime-libraries-coreclr outerloop

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

This was referenced Jun 16, 2023
Closed
Closed
@antonfirsov
Copy link
Member

antonfirsov commented Jun 19, 2023 •
edited

I could not find functional public proxy for testing.

Have you considered running mitmproxy locally? We could even configure it in our enterprise tests to have proper E2E automated testing.

@wfurt
Copy link
Member Author

wfurt commented Jun 19, 2023

I could not find functional public proxy for testing.

Have you considered running mitmproxy locally? We could even configure it in our enterprise tests to have proper E2E automated testing.

I can look into it. I originally wanted come public proxy on Internet.

@stephentoub stephentoub merged commit 28151b5 into dotnet:main Jun 22, 2023
104 of 106 checks passed
@antonfirsov antonfirsov mentioned this pull request Jul 17, 2023
Merged
@dotnet dotnet locked as resolved and limited conversation to collaborators Jul 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MihaZupan MihaZupan MihaZupan left review comments

@stephentoub stephentoub stephentoub approved these changes

@karelz karelz karelz approved these changes

Assignees

@wfurt wfurt

Labels
area-System.Net.Http
Projects
None yet
Milestone
8.0.0
Development

Successfully merging this pull request may close these issues.

HTTPS Proxy support feature requests
5 participants
@wfurt @antonfirsov @stephentoub @karelz @MihaZupan