Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement unidirectional GeneratedComInterface options #87831

Merged

Conversation

jkoritzinsky
Copy link
Member

Fixes #86360

We don't have a good hook to stop casting to a generated COM interface, so casts to "managed object wrapper"-only interfaces would still succeed if the QI is successful, but calling any methods would fail. Given that we expect most interfaces to use the default bidirectional behavior and only use the unidirectional cases for scenarios when they know it will only be used in one direction, I think the behavior is fine.

@dotnet-issue-labeler
Copy link

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@ghost ghost assigned jkoritzinsky Jun 20, 2023
@ghost
Copy link

ghost commented Jun 20, 2023

Tagging subscribers to this area: @dotnet/interop-contrib
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #86360

We don't have a good hook to stop casting to a generated COM interface, so casts to "managed object wrapper"-only interfaces would still succeed if the QI is successful, but calling any methods would fail. Given that we expect most interfaces to use the default bidirectional behavior and only use the unidirectional cases for scenarios when they know it will only be used in one direction, I think the behavior is fine.

Author: jkoritzinsky
Assignees: -
Labels:

area-System.Runtime.InteropServices, source-generator

Milestone: 8.0.0

Copy link
Member

@jtschuster jtschuster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jkoritzinsky jkoritzinsky merged commit ffe7c65 into dotnet:main Jun 21, 2023
111 checks passed
@jkoritzinsky jkoritzinsky deleted the directional-generatedcominterface branch June 21, 2023 21:19
@ghost ghost locked as resolved and limited conversation to collaborators Jul 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[API Proposal]: Expose options to only generate one direction for generated COM interfaces
2 participants