Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GC.KeepAlive to COM paths in WeakReference #88537

Merged
merged 3 commits into from
Jul 12, 2023

Conversation

markples
Copy link
Member

@markples markples commented Jul 7, 2023

Omission was noticed by @AustinWise. I reproed the failure and this fix for it on linux-x64.

Fixes #81362

@dotnet-issue-labeler dotnet-issue-labeler bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Jul 7, 2023
@ghost ghost assigned markples Jul 7, 2023
@markples
Copy link
Member Author

markples commented Jul 7, 2023

/azp run runtime-coreclr gcstress-extra

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@markples markples added this to the 8.0.0 milestone Jul 7, 2023
@jkotas jkotas added area-Interop-coreclr and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Jul 7, 2023
@markples
Copy link
Member Author

/azp run runtime

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@markples
Copy link
Member Author

cpuid* and widespread linux arm64 gcstress failures are preexisting

@markples
Copy link
Member Author

@VSadov could you please review this?

@markples markples marked this pull request as ready for review July 12, 2023 08:20
Copy link
Member

@VSadov VSadov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@markples markples merged commit a3c21b9 into dotnet:main Jul 12, 2023
183 of 190 checks passed
@ghost ghost locked as resolved and limited conversation to collaborators Aug 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test failure: Interop/COM/ComWrappers/WeakReference/WeakReferenceTest
4 participants