Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure that the CpuId tests set preferredVectorByteLength to a non-zero value #88623

Merged
merged 3 commits into from Jul 11, 2023

Conversation

tannergooding
Copy link
Member

@tannergooding tannergooding commented Jul 10, 2023

This resolves #88581 and resolves #88582 and resolves #88580

@dotnet-issue-labeler dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Jul 10, 2023
@ghost ghost assigned tannergooding Jul 10, 2023
@ghost
Copy link

ghost commented Jul 10, 2023

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Issue Details

This resolves #88581

Author: tannergooding
Assignees: -
Labels:

area-CodeGen-coreclr

Milestone: -

@tannergooding
Copy link
Member Author

/azp run runtime-coreclr jitstress-isas-x86, runtime-coreclr outerloop, runtime-coreclr jitstress, runtime-coreclr libraries-jitstress

@azure-pipelines
Copy link

Azure Pipelines successfully started running 4 pipeline(s).

@tannergooding
Copy link
Member Author

/azp run runtime-coreclr jitstress-isas-x86, runtime-coreclr outerloop, runtime-coreclr jitstress, runtime-coreclr libraries-jitstress

@azure-pipelines
Copy link

Azure Pipelines successfully started running 4 pipeline(s).

@tannergooding
Copy link
Member Author

/azp run runtime-coreclr jitstress-isas-x86, runtime-coreclr outerloop, runtime-coreclr jitstress, runtime-coreclr libraries-jitstress

@azure-pipelines
Copy link

No commit pushedDate could be found for PR 88623 in repo dotnet/runtime

@tannergooding
Copy link
Member Author

/azp run runtime-coreclr jitstress-isas-x86, runtime-coreclr outerloop, runtime-coreclr jitstress, runtime-coreclr libraries-jitstress

@azure-pipelines
Copy link

Azure Pipelines successfully started running 4 pipeline(s).

@tannergooding
Copy link
Member Author

CC. @dotnet/jit-contrib. This resolves #88581 and resolves #88582 and resolves #88580

The two main issues were that PreferredVectorByteWidth was being tied to the jit-stress mode, which made it non-deterministic and differ per-method. This broke cases like Vector512.IsHardwareAccelerated.

Additionally, the check around IsHardwareAccelerated itself wasn't properly conditioned and could differ in some scenarios, leading to other issues and inconsistencies.

This fixes both of those issues and ensures the tests are taking the preferred width into account so they pass as expected.

Copy link
Member

@AndyAyersMS AndyAyersMS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like the stress mode might be salvageable somehow, but let's sort that out later.

@tannergooding
Copy link
Member Author

Seems like the stress mode might be salvageable somehow, but let's sort that out later.

It's worth noting that we are explicitly testing PreferredVectorBitWidth=512 in stress already, so it wasn't buying us much.

@tannergooding
Copy link
Member Author

@dotnet-policy-service rerun

@tannergooding
Copy link
Member Author

There are still some stress failures, but unrelated to this PR in particular.

@tannergooding tannergooding merged commit 83bf4b6 into dotnet:main Jul 11, 2023
239 of 253 checks passed
@tannergooding tannergooding deleted the vector512-ci branch July 11, 2023 22:26
@dotnet dotnet locked as resolved and limited conversation to collaborators Aug 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Projects
None yet
2 participants