Simplify KeyAnalyzer #88709
Merged
Simplify KeyAnalyzer #88709
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The assignment `bool canSwitchIgnoreCaseToCaseSensitive = ignoreCase;` can just be `bool canSwitchIgnoreCaseToCaseSensitive = true;` since we're just tested that value a couple lines up
ghost
added
the
community-contribution
|
Tagging subscribers to this area: @dotnet/area-system-collections Issue DetailsJust a trivial code-review item. The assignment
|
IDisposable
commented
Jul 12, 2023
| @@ -124,7 +124,7 @@ private static bool TryUseSubstring(ReadOnlySpan<string> uniqueStrings, bool ign | |||
| // actually perform the comparison as case-sensitive even if case-insensitive | |||
| // was requested, as there's nothing that would compare equally to the substring | |||
| // other than the substring itself. | |||
| bool canSwitchIgnoreCaseToCaseSensitive = ignoreCase; | |||
| bool canSwitchIgnoreCaseToCaseSensitive = true; | |||
stephentoub
approved these changes
Jul 17, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a trivial code-review item. The assignment
bool canSwitchIgnoreCaseToCaseSensitive = ignoreCase;can just bebool canSwitchIgnoreCaseToCaseSensitive = true;since we're just tested that value a couple lines up withif (ignoreCase). This DOES emit different code at the IL level.