Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature to be able to selectively deoptimize methods #88797

Merged
merged 11 commits into from Jul 14, 2023
Merged

Feature to be able to selectively deoptimize methods #88797

merged 11 commits into from Jul 14, 2023

Conversation

davmason
Copy link
Member

No description provided.

@davmason davmason added this to the 8.0.0 milestone Jul 12, 2023
@davmason davmason requested a review from a team July 12, 2023 23:00
@davmason davmason self-assigned this Jul 12, 2023
@ghost
Copy link

ghost commented Jul 12, 2023

Tagging subscribers to this area: @tommcdon
See info in area-owners.md if you want to be subscribed.

Issue Details

null

Author: davmason
Assignees: davmason
Labels:

area-Diagnostics-coreclr
Milestone: 8.0.0

hoyosjs
hoyosjs reviewed Jul 13, 2023
View reviewed changes
src/coreclr/debug/di/rsfunction.cpp
CordbAppDomain * pAppDomain = GetAppDomain();
_ASSERTE (pAppDomain != NULL);

pProcess->InitIPCEvent(&event, DB_IPCE_IS_OPTS_DISABLED, true, pAppDomain->GetADToken());
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the process is stopped to be able to do this inspection - is there any reason to not ask this question though the DAC?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is already tested and ready to go my plan is to check it in as is and do a follow up PR to address this and the GetFunctionAddress question

This was referenced Jul 13, 2023
Closed
Closed
mikelle-rogers and others added 9 commits July 13, 2023 14:31
@mikelle-rogers @davmason
rebase
46f833d 
removing some code

working on the tiered portion

commit the changes

initial commit for ICorDebugFunction5 DisableOpimizations

removing some code

working on the tiered portion

only enter API once
@davmason
Updates
bd90e25 
Update rsfunction.cpp

inliners, but there's a problem

Backing up

WIP

WIP

Fix lock ordering and allow debugger thread to access locks

Add method

Update functioninfo.cpp
@davmason
Update generated files after rebase
825cd9f
@davmason
Update task.cpp
ce731b3
@davmason
Refactor
ede3436
@davmason
Feedback
994fff5
@davmason
Feedback
45411c5
@davmason
Feedback
1d57cee
@davmason
Update cordebug.h
16f7265
This was referenced Jul 14, 2023
Closed
Closed
@hoyosjs hoyosjs merged commit b4118a6 into dotnet:main Jul 14, 2023
95 of 107 checks passed
@hoyosjs
Copy link
Member

hoyosjs commented Jul 14, 2023

All failures are known.

@ghost ghost locked as resolved and limited conversation to collaborators Aug 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hoyosjs hoyosjs hoyosjs approved these changes

Assignees

@davmason davmason

Labels
area-Diagnostics-coreclr
Projects
None yet
Milestone
8.0.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@davmason @hoyosjs @mikelle-rogers