Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix use-out-of-scope in signature comparison #88928

Merged
merged 5 commits into from Jul 15, 2023
Merged

Fix use-out-of-scope in signature comparison #88928

merged 5 commits into from Jul 15, 2023

Conversation

jkoritzinsky
Copy link
Member

@jkoritzinsky jkoritzinsky commented Jul 14, 2023 •
edited

Propagate token list to callers by copying instead of passing an out-of-scope address.

Fixes a violation found by ASAN.

Fixes the underlying issue in #87807

This PR is blocking #74623 (the ASAN enabling PR) from being green.

@ghost ghost assigned jkoritzinsky Jul 14, 2023
@ghost
Copy link

ghost commented Jul 14, 2023

Tagging subscribers to this area: @hoyosjs
See info in area-owners.md if you want to be subscribed.

Issue Details

Propagate token list to callers by copying instead of passing an out-of-scope address.

Fixes a violation found by ASAN.

Fixes the underlying issue in #87807

Author: jkoritzinsky
Assignees: jkoritzinsky
Labels:

area-Infrastructure-coreclr
Milestone: -

@jkoritzinsky jkoritzinsky added this to the 8.0.0 milestone Jul 14, 2023
@jkoritzinsky jkoritzinsky marked this pull request as ready for review July 14, 2023 18:59
@jkoritzinsky jkoritzinsky added the blocking Marks issues that we want to fast track in order to unblock other important work label Jul 14, 2023
@jkoritzinsky jkoritzinsky mentioned this pull request Jul 14, 2023
Merged
AaronRobinsonMSFT
AaronRobinsonMSFT approved these changes Jul 14, 2023
View reviewed changes
Copy link
Member

@AaronRobinsonMSFT AaronRobinsonMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@jkoritzinsky
Copy link
Member Author

Only failure is a timeout:

@jkoritzinsky jkoritzinsky merged commit 2d1d727 into dotnet:main Jul 15, 2023
104 of 107 checks passed
@jkoritzinsky jkoritzinsky deleted the asan-fixes branch July 15, 2023 02:05
@dotnet dotnet locked as resolved and limited conversation to collaborators Aug 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@AaronRobinsonMSFT AaronRobinsonMSFT AaronRobinsonMSFT approved these changes

@jkotas jkotas Awaiting requested review from jkotas

Assignees

@jkoritzinsky jkoritzinsky

Labels
area-VM-coreclr blocking Marks issues that we want to fast track in order to unblock other important work
Projects
None yet
Milestone
8.0.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jkoritzinsky @AaronRobinsonMSFT