Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use a HashSet instead of Dictionary in XNodeValidator #89030

Merged
merged 1 commit into from
Jul 17, 2023
Merged

Use a HashSet instead of Dictionary in XNodeValidator #89030

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/libraries/System.Private.Xml.Linq/src/System/Xml/Schema/XNodeValidator.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ internal sealed class XNodeValidator
private XmlNamespaceManager? namespaceManager;
private XmlSchemaValidator? validator;

private Dictionary<XmlSchemaInfo, XmlSchemaInfo>? schemaInfos;
private HashSet<XmlSchemaInfo>? schemaInfos;
private ArrayList? defaultAttributes;
private readonly XName xsiTypeName;
private readonly XName xsiNilName;
Expand Down Expand Up @@ -153,17 +153,17 @@ private XmlSchemaInfo GetDefaultAttributeSchemaInfo(XmlSchemaAttribute sa)

private void ReplaceSchemaInfo(XObject o, XmlSchemaInfo schemaInfo)
{
schemaInfos ??= new Dictionary<XmlSchemaInfo, XmlSchemaInfo>(new XmlSchemaInfoEqualityComparer());
schemaInfos ??= new HashSet<XmlSchemaInfo>(new XmlSchemaInfoEqualityComparer());
XmlSchemaInfo? si = o.Annotation<XmlSchemaInfo>();
if (si != null)
{
schemaInfos.TryAdd(si, si);
schemaInfos.Add(si);
o.RemoveAnnotations<XmlSchemaInfo>();
}
if (!schemaInfos.TryGetValue(schemaInfo, out si))
{
si = schemaInfo;
schemaInfos.Add(si, si);
schemaInfos.Add(si);
}
o.AddAnnotation(si);
}
Expand Down