Build less of libs for NativeAOT testing #89153
Conversation
We don't care about any of the System.Speech, Microsoft.Extensions.*,... stuff.
|
Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas Issue DetailsWe don't care about any of the System.Speech, Microsoft.Extensions.*,... stuff. Made possible with #89005. Cc @dotnet/ilc-contrib
|
Similar to #89153. I don't think we need System.Speech & co for tools tests.
| @@ -208,7 +208,7 @@ extends: | |||
| jobParameters: | |||
| timeoutInMinutes: 120 | |||
| nameSuffix: NativeAOT | |||
| buildArgs: -s clr.aot+host.native+libs -rc $(_BuildConfig) -lc Release -hc Release | |||
| buildArgs: -s clr.aot+host.native+libs.sfx+libs.native -rc $(_BuildConfig) -lc Release -hc Release | |||
There was a problem hiding this comment.
nit: build libs.native before libs.sfx. That's the expected order...
|
Looking at the test failures, looks like EventPipe testing relies on some Microsoft.Extensions crap and since we test EventPipe as part of smoke tests now, we need the whole product. This would have been enough 6 months ago when we didn't have EventPipe, but not anymore. Oh well :'(. |
|
I'm still going to use this in my personal workflows though because I don't run event pipe testing, so @ViktorHofer your #89005 is still super useful. |
|
As discussed offline with Michal, this would work just fine if the runtime tests in question could use ProjectReferences and bring in the required out-of-band libraries that are needed by the specific tests. Given that the current infra around runtime tests is fragile around PackageReferences/ProjectReferences we will not pursue this further at this point. cc @jkoritzinsky |
|
Once we do part two of test consolidation, we can revisit this. |
Similar to #89153. I don't think we need System.Speech & co for tools tests.
ghost
locked as resolved and limited conversation to collaborators
We don't care about any of the System.Speech, Microsoft.Extensions.*,... stuff.
Made possible with #89005.
Cc @dotnet/ilc-contrib