Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide IntrospectionExtensions.GetTypeInfo #89317

Merged
merged 1 commit into from
Aug 3, 2023

Conversation

huoyaoyuan
Copy link
Member

Fixes #53217

@dotnet-issue-labeler
Copy link

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Jul 21, 2023
@ghost
Copy link

ghost commented Jul 21, 2023

Tagging subscribers to this area: @dotnet/area-system-reflection
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #53217

Author: huoyaoyuan
Assignees: -
Labels:

area-System.Reflection, new-api-needs-documentation

Milestone: -

@huoyaoyuan
Copy link
Member Author

Delaying according to #53217 (comment)

@steveharter
Copy link
Member

Delaying according to #53217 (comment)

We could get this PR in, then I can create a new issue for the newer feedback.

@steveharter steveharter self-requested a review August 3, 2023 21:27
Copy link
Member

@steveharter steveharter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addresses the linked issue, but I'll create another issue for additional feedback that was added to the issue.

@steveharter steveharter merged commit 6e30ad4 into dotnet:main Aug 3, 2023
165 of 168 checks passed
@huoyaoyuan huoyaoyuan deleted the typeinfo branch August 4, 2023 04:08
@ghost ghost locked as resolved and limited conversation to collaborators Sep 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-System.Reflection community-contribution Indicates that the PR has been added by a community member new-api-needs-documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Proposal: obsolete or hide TypeInfo/GetTypeInfo
2 participants