Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introducing TimeZoneInfo.GetSystemTimeZones(bool skipSorting) #89985

Merged
merged 2 commits into from Aug 4, 2023

Conversation

tarekgh
Copy link
Member

@tarekgh tarekgh commented Aug 4, 2023

Fixes #88691

@dotnet-issue-labeler
Copy link

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@ghost ghost assigned tarekgh Aug 4, 2023
@ghost
Copy link

ghost commented Aug 4, 2023

Tagging subscribers to this area: @dotnet/area-system-datetime
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #88691

Author: tarekgh
Assignees: -
Labels:

new-api-needs-documentation, area-System.DateTime

Milestone: -

@tarekgh tarekgh requested a review from mdh1418 August 4, 2023 00:08
Copy link
Member

@mdh1418 mdh1418 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@tarekgh tarekgh merged commit cbe4aa4 into dotnet:main Aug 4, 2023
166 of 168 checks passed
@tarekgh tarekgh deleted the IntroduceUnSortedGetSystemTimeZones branch August 4, 2023 22:27
@JeroenBer
Copy link

@tarekgh Thanks, that is great news! :) Is there any way I can get this build or compile it myself to test it ? Is there any doc for that somewhere ?

@tarekgh
Copy link
Member Author

tarekgh commented Aug 6, 2023

@mdh1418 could you please help @JeroenBer how he can get Android build?

@mdh1418
Copy link
Member

mdh1418 commented Aug 7, 2023

Hi @JeroenBer, if you're looking to use a nightly build of the .NET 8 sdk containing the change, its not available yet. We would first need the dotnet/sdk to merge dotnet/sdk#34477.

Otherwise, I can try to get you the relevant .nupkg's that you can use to update your local versions of the packages.

If you want to try it right now, provided you dont need a signed build, I believe the way to go would be to build https://github.com/xamarin/xamarin-android/tree/main and updating the commit hash pointing towards a build of dotnet/runtime at https://github.com/xamarin/xamarin-android/blob/main/eng/Version.Details.xml

Edit: Actually I'm not sure it'll be easy to grab the right pieces for you to work with until the changes flow into dotnet/installer, which might take a few days.

@mdh1418
Copy link
Member

mdh1418 commented Aug 15, 2023

@JeroenBer it looks like the installer PR merged dotnet/installer#17118, so I believe the main column in the table should be an SDK that contains the change 8.0.100-rc.1.23415.6

@dotnet dotnet locked as resolved and limited conversation to collaborators Sep 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[API Proposal]: Add variation of TimeZoneInfo.GetSystemTimeZones() not sorted on DisplayName
4 participants