New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introducing TimeZoneInfo.GetSystemTimeZones(bool skipSorting) #89985
Introducing TimeZoneInfo.GetSystemTimeZones(bool skipSorting) #89985
Conversation
Note regarding the This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change. |
Tagging subscribers to this area: @dotnet/area-system-datetime Issue DetailsFixes #88691
|
src/libraries/System.Private.CoreLib/src/System/TimeZoneInfo.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
@tarekgh Thanks, that is great news! :) Is there any way I can get this build or compile it myself to test it ? Is there any doc for that somewhere ? |
@mdh1418 could you please help @JeroenBer how he can get Android build? |
Hi @JeroenBer, if you're looking to use a nightly build of the .NET 8 sdk containing the change, its not available yet. We would first need the dotnet/sdk to merge dotnet/sdk#34477. Otherwise, I can try to get you the relevant If you want to try it right now, provided you dont need a signed build, I believe the way to go would be to build https://github.com/xamarin/xamarin-android/tree/main and updating the commit hash pointing towards a build of dotnet/runtime at https://github.com/xamarin/xamarin-android/blob/main/eng/Version.Details.xml Edit: Actually I'm not sure it'll be easy to grab the right pieces for you to work with until the changes flow into |
@JeroenBer it looks like the installer PR merged dotnet/installer#17118, so I believe the main column in the table should be an SDK that contains the change |
Fixes #88691