Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify invalid hostname check in DomainNameHelper #90088

Merged
merged 1 commit into from Aug 7, 2023

Conversation

MihaZupan
Copy link
Member

Now that SearchValues will do a good job of handling mixed ASCII and non-ASCII values like these (#89155, #89981), we can avoid the separate 0x80-0x9F search.

@MihaZupan MihaZupan self-assigned this Aug 7, 2023
@ghost
Copy link

ghost commented Aug 7, 2023

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

Now that SearchValues will do a good job of handling mixed ASCII and non-ASCII values like these (#89155, #89981), we can avoid the separate 0x80-0x9F search.

Author: MihaZupan
Assignees: MihaZupan
Labels:

area-System.Net

Milestone: -

Copy link
Member

@wfurt wfurt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MihaZupan MihaZupan merged commit 59dba61 into dotnet:main Aug 7, 2023
103 checks passed
@MihaZupan MihaZupan added this to the 8.0.0 milestone Aug 7, 2023
@dotnet dotnet locked as resolved and limited conversation to collaborators Sep 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants