For perf, use the new ConstructorInvoker APIs for ActivatorUtilities.CreateFactory #90119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
steveharter
added
tenet-performance
|
Tagging subscribers to this area: @dotnet/area-extensions-dependencyinjection Issue DetailsRe-commit the original + a fix for NativeAot.
|
steveharter
changed the title
jkotas
reviewed
Aug 7, 2023
src/coreclr/nativeaot/System.Private.CoreLib/src/System/Reflection/ConstructorInvoker.cs
Show resolved
Hide resolved
src/coreclr/nativeaot/System.Private.CoreLib/src/System/Reflection/ConstructorInvoker.cs
Outdated
Show resolved
Hide resolved
|
/azp run runtime-extra-platforms |
|
Azure Pipelines successfully started running 1 pipeline(s). |
jkotas
reviewed
Aug 8, 2023
src/coreclr/nativeaot/System.Private.CoreLib/src/System/Reflection/ConstructorInvoker.cs
Outdated
Show resolved
Hide resolved
This was referenced Aug 8, 2023
|
/azp run runtime-extra-platforms |
|
Azure Pipelines successfully started running 1 pipeline(s). |
jkotas
approved these changes
Aug 9, 2023
|
This should fix #90039 |
This was referenced Aug 10, 2023
|
The runtime-extra-platforms CI errors appear unrelated; created some new tracking issues. Verified library tests with NativeAot locally. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-commit the original + fix NativeAot + make core API validation consistent with NativeAot.