Support new Options attributes in the Runtime #90275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
|
Tagging subscribers to this area: @dotnet/area-extensions-options Issue DetailsContribute to #87844 We have introduced two new data validation attributes
|
src/libraries/Microsoft.Extensions.Options.DataAnnotations/src/DataAnnotationValidateOptions.cs
Show resolved
Hide resolved
src/libraries/Microsoft.Extensions.Options.DataAnnotations/src/DataAnnotationValidateOptions.cs
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
Aug 10, 2023
src/libraries/Microsoft.Extensions.Options.DataAnnotations/src/DataAnnotationValidateOptions.cs
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
Aug 10, 2023
src/libraries/Microsoft.Extensions.Options.DataAnnotations/src/DataAnnotationValidateOptions.cs
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
Aug 10, 2023
src/libraries/Microsoft.Extensions.Options.DataAnnotations/src/DataAnnotationValidateOptions.cs
Show resolved
Hide resolved
eiriktsarpalis
approved these changes
Aug 10, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribute to #87844
We have introduced two new data validation attributes
ValidateObjectMembersAttributeandValidateEnumeratedItemsAttribute. These attributes are used inside Options source generator. This change is to support the attributes in the Runtime too so options validation will be consistent between the source generator and Runtime.