-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add timeouts to SendReceive tests #90631
Conversation
/azp run runtime-libraries-coreclr outerloop |
Azure Pipelines successfully started running 1 pipeline(s). |
Tagging subscribers to this area: @dotnet/ncl Issue DetailsFixes #89784, meaning that the change should convert process timeouts to test failures. The root cause of the
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
I'm not sure if that will fix the hangs - as it looked to me as it may be in synchronous calls and I'm not sure if adding timorous to the async tasks will be sufficient ... but it may and I see it as improvement.
We use |
Fixes #89784, meaning that the change should convert process timeouts to test failures.
The root cause of the
SendRecv_Stream_TCP
timeout is most likely a dual-mode socket connecting to the tests' listener socket in a parallel test, but I am hesitant to add a fix for that without a proof.