Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add timeouts to SendReceive tests #90631

Merged
merged 1 commit into from
Aug 16, 2023

Conversation

antonfirsov
Copy link
Member

@antonfirsov antonfirsov commented Aug 15, 2023

Fixes #89784, meaning that the change should convert process timeouts to test failures.

The root cause of the SendRecv_Stream_TCP timeout is most likely a dual-mode socket connecting to the tests' listener socket in a parallel test, but I am hesitant to add a fix for that without a proof.

@antonfirsov
Copy link
Member Author

/azp run runtime-libraries-coreclr outerloop

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ghost
Copy link

ghost commented Aug 15, 2023

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #89784, meaning that the change should convert process timeouts to test failures.

The root cause of the SendRecv_Stream_TCP timeout is most likely a dual-mode socket connecting to the tests' listener socket in a parallel test, but I am hesitant to add a fix for that without a proof.

Author: antonfirsov
Assignees: antonfirsov
Labels:

area-System.Net.Sockets

Milestone: -

Copy link
Member

@wfurt wfurt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
I'm not sure if that will fix the hangs - as it looked to me as it may be in synchronous calls and I'm not sure if adding timorous to the async tasks will be sufficient ... but it may and I see it as improvement.

@antonfirsov
Copy link
Member Author

antonfirsov commented Aug 16, 2023

I'm not sure if that will fix the hangs - as it looked to me as it may be in synchronous calls

We use Task.Run() in the synchronous case, and await Task.Run(...).WaitAsync(t) should timeout when t has been passed, regardless of the inner (blocking) action still running in the background.

@antonfirsov
Copy link
Member Author

CI failures are unrelated: #90603 #90639 #68246

@antonfirsov antonfirsov merged commit 305506c into dotnet:main Aug 16, 2023
105 of 113 checks passed
@karelz karelz added this to the 9.0.0 milestone Aug 29, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Sep 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Long Running Test] 'System.Net.Sockets.Tests.SendReceive_SyncForceNonBlocking.SendRecv_Stream_TCP'
4 participants