Binder gen incremental final #92654
Closed
Binder gen incremental final #92654
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @dotnet/area-extensions-configuration Issue Detailsvisualizing to get minimal diff
|
layomia
force-pushed
the
binder-gen-incremental-final
branch
8 times, most recently
from
ebba9ae
to
42889ea
Compare
layomia
commented
Sep 26, 2023
|
|
||
| public static string GetConfigKeyCacheFieldName(ObjectSpec type) => $"s_configKeys_{type.IdentifierCompatibleSubstring}"; | ||
|
|
||
| public static string GetParseMethodName(ParsableFromStringSpec type) |
There was a problem hiding this comment.
9:0 - switch to using type.IdentifierCompatibleSubstring.
layomia
commented
Sep 26, 2023
Comment on lines
+157
to
+160
| // List<string> is used in generated code as a temp holder for formatting | ||
| // an error for config properties that don't map to object properties. | ||
| _namespaces.Add("System.Collections.Generic"); |
There was a problem hiding this comment.
9.0: only add when object has complex members.
layomia
commented
Sep 26, 2023
| "Microsoft.Extensions.Configuration", | ||
| }; | ||
|
|
||
| public BindingHelperInfo ToIncrementalValue() |
There was a problem hiding this comment.
9.0: reinstate sorting for equatable arrays where possible e.g. changing property order shouldn't cause regeneration.
layomia
force-pushed
the
binder-gen-incremental-final
branch
from
42889ea
to
e896d99
Compare
layomia
force-pushed
the
binder-gen-incremental-final
branch
from
e896d99
to
d87fb68
Compare
|
Merged #89587. |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
visualizing to get minimal diff