Implement Interlocked for small types. #92974

MichalPetryka · 2023-10-03T23:24:29Z

Implements Interlocked.CompareExchange/Exchange for byte/sbyte/short/ushort.

Uses an intrinsic on CoreCLR x64 and ARM64 and fallbacks for other platforms.

Implements Interlocked.CompareExchange/Exchange for byte/sbyte/short/ushort. Uses an intrinsic on CoreCLR x64 and ARM64 and fallbacks for other platforms. Fixes dotnet#64658.

dotnet-issue-labeler · 2023-10-03T23:24:34Z

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

ghost · 2023-10-03T23:24:39Z

Tagging subscribers to this area: @mangod9
See info in area-owners.md if you want to be subscribed.

Issue Details

Implements Interlocked.CompareExchange/Exchange for byte/sbyte/short/ushort.

Uses an intrinsic on CoreCLR x64 and ARM64 and fallbacks for other platforms.

Fixes #64658.

Author:	MichalPetryka
Assignees:	-
Labels:	`area-System.Threading`, `new-api-needs-documentation`
Milestone:	-

src/libraries/System.Threading/tests/InterlockedTests.cs

src/mono/mono/utils/atomic.h

jkotas · 2024-01-24T15:24:06Z

@jkotas I've realised there's a potential issue with atomics as FCalls: some compilers might implement them with locking on a mutex which AFAIR is not okay inside of an FCall. Checking with CLang on godbolt makes it seem to be the case on arm32.

These are results for stdatomic.h header. We do not use stdatomic.h. We use the compiler intrinsics directly. You may want to step through the disassembly on arm32 to see what the compiler intrinsics end up doing.

MichalPetryka · 2024-01-24T15:32:06Z

@jkotas I've realised there's a potential issue with atomics as FCalls: some compilers might implement them with locking on a mutex which AFAIR is not okay inside of an FCall. Checking with CLang on godbolt makes it seem to be the case on arm32.

These are results for stdatomic.h header. We do not use stdatomic.h. We use the compiler intrinsics directly. You may want to step through the disassembly on arm32 to see what the compiler intrinsics end up doing.

I've checked that earlier, it calls into a __atomic_exchange_1/2/4/8 helper (which means it probably implicitly links libatomic there). It does a similar thing for arm 8.0, just with __aarch64_swp1_acq_rel (which is fine according to that define).

Additionally, on arm32 it gives such warning:

<source>:5:12: warning: large atomic operation may incur significant performance penalty; the access size (1 bytes) exceeds the max lock-free size (0  bytes) [-Watomic-alignment]
    5 |     return __atomic_exchange_n(ptr, val, __ATOMIC_ACQ_REL);
<source>:9:12: warning: large atomic operation may incur significant performance penalty; the access size (2 bytes) exceeds the max lock-free size (0  bytes) [-Watomic-alignment]
    9 |     return __atomic_exchange_n(ptr, val, __ATOMIC_ACQ_REL);
<source>:13:12: warning: large atomic operation may incur significant performance penalty; the access size (4 bytes) exceeds the max lock-free size (0  bytes) [-Watomic-alignment]
   13 |     return __atomic_exchange_n(ptr, val, __ATOMIC_ACQ_REL);
<source>:17:12: warning: large atomic operation may incur significant performance penalty; the access size (8 bytes) exceeds the max lock-free size (0  bytes) [-Watomic-alignment]
   17 |     return __atomic_exchange_n(ptr, val, __ATOMIC_ACQ_REL);

jkotas · 2024-01-24T16:00:05Z

It is a problem with __atomic_exchange_n that is used for InterlockedExchange. __atomic_exchange_n is also the one that caused troubles on Linux x86 before.

Other operations are implemented using __sync_val_... intrinsics. Do __sync_val_... intrinsics have the same problem?

If __sync_val_... intrinsics are fine:

Use __sync_swap to implement InterlockedExchange when compiling using LLVM. We do that here already:

runtime/src/coreclr/nativeaot/Runtime/unix/PalRedhawkInline.h

Lines 30 to 34 in d3583b8

    
           #ifdef __clang__ 
        
               return __sync_swap(pDst, iValue); 
        
           #else 
        
               return __atomic_exchange_n(pDst, iValue, __ATOMIC_ACQ_REL); 
        
           #endif

Implement InterlockedExchange using __sync_val_compare_and_swap when not compiling using LLVM. Similar to what I have done to fix the Linux x86 break:

runtime/src/coreclr/pal/inc/pal.h

Lines 3645 to 3661 in d3583b8

    
           #if defined(HOST_X86) 
        
           // 64-bit __atomic_exchange_n is not expanded as a compiler intrinsic on Linux x86. 
        
           // Use inline implementation instead. 
        
           inline LONGLONG InterlockedExchange64(LONGLONG volatile * Target, LONGLONG Value) 
        
           { 
        
               LONGLONG Old; 
        
               do { 
        
                   Old = *Target; 
        
               } while (__sync_val_compare_and_swap(Target, Old, Value) != Old); 
        
               return Old; 
        
           } 
        
           #else

MichalPetryka · 2024-01-24T16:12:57Z

I've opened a new issue to track this as this PR doesn't introduce the issue: #97452.

MichalPetryka · 2024-01-24T16:29:17Z

~~ARM32 failure seems like an unrelated JIT bug with longs.~~
Turns out a small bug in the helpers somehow trashed the stack.

jkotas · 2024-01-24T16:38:48Z

I've opened a new issue to track this as this PR doesn't introduce the issue: #97452.

It does not introduce it, but it makes the problem worse. Could you please replace the new uses of __atomic_exchange_n with what I have suggested? It should address the issue. (Bonus points for fixing the existing uses too.)

MichalPetryka · 2024-01-24T16:40:53Z

I've opened a new issue to track this as this PR doesn't introduce the issue: #97452.

It does not introduce it, but it makes the problem worse. Could you please replace the new uses of __atomic_exchange_n with what I have suggested? It should address the issue. (Bonus points for fixing the existing uses too.)

As I've noted in that issue, those other APIs also use helper calls so I'd assume they have the same issue.

ryujit-bot · 2024-01-24T18:00:05Z

Diff results for #92974

Throughput diffs

Throughput diffs for linux/x64 ran on windows/x64

Overall (+0.00% to +0.02%)

Collection	PDIFF
benchmarks.run.linux.x64.checked.mch	+0.01%
benchmarks.run_pgo.linux.x64.checked.mch	+0.01%
benchmarks.run_tiered.linux.x64.checked.mch	+0.02%
coreclr_tests.run.linux.x64.checked.mch	+0.01%
libraries.pmi.linux.x64.checked.mch	+0.01%
libraries_tests.run.linux.x64.Release.mch	+0.01%
libraries_tests_no_tiered_compilation.run.linux.x64.Release.mch	+0.01%
realworld.run.linux.x64.checked.mch	+0.01%

MinOpts (+0.01% to +0.03%)

Collection	PDIFF
benchmarks.run.linux.x64.checked.mch	+0.03%
benchmarks.run_pgo.linux.x64.checked.mch	+0.03%
benchmarks.run_tiered.linux.x64.checked.mch	+0.03%
coreclr_tests.run.linux.x64.checked.mch	+0.02%
libraries.crossgen2.linux.x64.checked.mch	+0.03%
libraries.pmi.linux.x64.checked.mch	+0.01%
libraries_tests.run.linux.x64.Release.mch	+0.03%
libraries_tests_no_tiered_compilation.run.linux.x64.Release.mch	+0.03%
realworld.run.linux.x64.checked.mch	+0.02%
smoke_tests.nativeaot.linux.x64.checked.mch	+0.01%

FullOpts (+0.00% to +0.01%)

Collection	PDIFF
benchmarks.run.linux.x64.checked.mch	+0.01%
benchmarks.run_pgo.linux.x64.checked.mch	+0.01%
benchmarks.run_tiered.linux.x64.checked.mch	+0.01%
libraries.pmi.linux.x64.checked.mch	+0.01%
libraries_tests.run.linux.x64.Release.mch	+0.01%
realworld.run.linux.x64.checked.mch	+0.01%

Throughput diffs for windows/x64 ran on windows/x64

Overall (-0.01% to -0.00%)

Collection	PDIFF
coreclr_tests.run.windows.x64.checked.mch	-0.01%
libraries.crossgen2.windows.x64.checked.mch	-0.01%
libraries_tests.run.windows.x64.Release.mch	-0.01%
smoke_tests.nativeaot.windows.x64.checked.mch	-0.01%

MinOpts (-0.02% to +0.00%)

Collection	PDIFF
aspnet.run.windows.x64.checked.mch	-0.01%
benchmarks.run_pgo.windows.x64.checked.mch	-0.01%
benchmarks.run_tiered.windows.x64.checked.mch	-0.01%
coreclr_tests.run.windows.x64.checked.mch	-0.01%
libraries.pmi.windows.x64.checked.mch	-0.02%
libraries_tests.run.windows.x64.Release.mch	-0.01%
realworld.run.windows.x64.checked.mch	-0.01%
smoke_tests.nativeaot.windows.x64.checked.mch	-0.02%

FullOpts (-0.01% to -0.00%)

Collection	PDIFF
libraries.crossgen2.windows.x64.checked.mch	-0.01%
smoke_tests.nativeaot.windows.x64.checked.mch	-0.01%

Details here

Throughput diffs for linux/x64 ran on linux/x64

Overall (-0.03% to -0.01%)

Collection	PDIFF
realworld.run.linux.x64.checked.mch	-0.01%
benchmarks.run.linux.x64.checked.mch	-0.01%
smoke_tests.nativeaot.linux.x64.checked.mch	-0.02%
libraries.pmi.linux.x64.checked.mch	-0.01%
benchmarks.run_tiered.linux.x64.checked.mch	-0.03%
benchmarks.run_pgo.linux.x64.checked.mch	-0.02%
libraries_tests_no_tiered_compilation.run.linux.x64.Release.mch	-0.01%
coreclr_tests.run.linux.x64.checked.mch	-0.03%
libraries.crossgen2.linux.x64.checked.mch	-0.02%
libraries_tests.run.linux.x64.Release.mch	-0.02%

MinOpts (-0.07% to -0.04%)

Collection	PDIFF
realworld.run.linux.x64.checked.mch	-0.05%
benchmarks.run.linux.x64.checked.mch	-0.06%
smoke_tests.nativeaot.linux.x64.checked.mch	-0.05%
libraries.pmi.linux.x64.checked.mch	-0.04%
benchmarks.run_tiered.linux.x64.checked.mch	-0.06%
benchmarks.run_pgo.linux.x64.checked.mch	-0.06%
libraries_tests_no_tiered_compilation.run.linux.x64.Release.mch	-0.05%
coreclr_tests.run.linux.x64.checked.mch	-0.04%
libraries.crossgen2.linux.x64.checked.mch	-0.07%
libraries_tests.run.linux.x64.Release.mch	-0.06%

FullOpts (-0.02% to -0.01%)

Collection	PDIFF
realworld.run.linux.x64.checked.mch	-0.01%
benchmarks.run.linux.x64.checked.mch	-0.01%
smoke_tests.nativeaot.linux.x64.checked.mch	-0.02%
libraries.pmi.linux.x64.checked.mch	-0.01%
benchmarks.run_tiered.linux.x64.checked.mch	-0.01%
benchmarks.run_pgo.linux.x64.checked.mch	-0.01%
libraries_tests_no_tiered_compilation.run.linux.x64.Release.mch	-0.01%
coreclr_tests.run.linux.x64.checked.mch	-0.01%
libraries.crossgen2.linux.x64.checked.mch	-0.02%
libraries_tests.run.linux.x64.Release.mch	-0.01%

Details here

Throughput diffs for windows/x86 ran on windows/x86

Overall (+0.00% to +0.01%)

Collection	PDIFF
benchmarks.run.windows.x86.checked.mch	+0.01%
benchmarks.run_tiered.windows.x86.checked.mch	+0.01%
coreclr_tests.run.windows.x86.checked.mch	+0.01%
libraries.crossgen2.windows.x86.checked.mch	+0.01%
libraries.pmi.windows.x86.checked.mch	+0.01%
libraries_tests.run.windows.x86.Release.mch	+0.01%
libraries_tests_no_tiered_compilation.run.windows.x86.Release.mch	+0.01%
realworld.run.windows.x86.checked.mch	+0.01%

MinOpts (+0.01% to +0.02%)

Collection	PDIFF
benchmarks.run.windows.x86.checked.mch	+0.01%
benchmarks.run_pgo.windows.x86.checked.mch	+0.01%
benchmarks.run_tiered.windows.x86.checked.mch	+0.01%
coreclr_tests.run.windows.x86.checked.mch	+0.01%
libraries.crossgen2.windows.x86.checked.mch	+0.01%
libraries.pmi.windows.x86.checked.mch	+0.02%
libraries_tests.run.windows.x86.Release.mch	+0.01%
libraries_tests_no_tiered_compilation.run.windows.x86.Release.mch	+0.01%
realworld.run.windows.x86.checked.mch	+0.01%

FullOpts (+0.00% to +0.01%)

Collection	PDIFF
benchmarks.run.windows.x86.checked.mch	+0.01%
libraries.crossgen2.windows.x86.checked.mch	+0.01%
libraries.pmi.windows.x86.checked.mch	+0.01%
libraries_tests_no_tiered_compilation.run.windows.x86.Release.mch	+0.01%
realworld.run.windows.x86.checked.mch	+0.01%

Details here

MichalPetryka · 2024-01-24T19:31:48Z

@MihuBot

ryujit-bot · 2024-01-24T19:36:43Z

Diff results for #92974

Throughput diffs

Throughput diffs for linux/x64 ran on windows/x64

Overall (+0.00% to +0.01%)

Collection	PDIFF
realworld.run.linux.x64.checked.mch	+0.01%

MinOpts (+0.01% to +0.02%)

Collection	PDIFF
realworld.run.linux.x64.checked.mch	+0.02%
smoke_tests.nativeaot.linux.x64.checked.mch	+0.01%

FullOpts (+0.00% to +0.01%)

Collection	PDIFF
realworld.run.linux.x64.checked.mch	+0.01%

Details here

Throughput diffs for linux/x64 ran on linux/x64

Overall (-0.02%)

Collection	PDIFF
smoke_tests.nativeaot.linux.x64.checked.mch	-0.02%

MinOpts (-0.05%)

Collection	PDIFF
smoke_tests.nativeaot.linux.x64.checked.mch	-0.05%

FullOpts (-0.02%)

Collection	PDIFF
smoke_tests.nativeaot.linux.x64.checked.mch	-0.02%

Details here

ryujit-bot · 2024-01-24T19:44:44Z

Diff results for #92974

Throughput diffs

Throughput diffs for linux/x64 ran on linux/x64

Overall (-0.03% to -0.01%)

Collection	PDIFF
smoke_tests.nativeaot.linux.x64.checked.mch	-0.02%
benchmarks.run.linux.x64.checked.mch	-0.01%
realworld.run.linux.x64.checked.mch	-0.01%
libraries_tests.run.linux.x64.Release.mch	-0.02%
benchmarks.run_tiered.linux.x64.checked.mch	-0.03%
libraries_tests_no_tiered_compilation.run.linux.x64.Release.mch	-0.01%
libraries.pmi.linux.x64.checked.mch	-0.01%
coreclr_tests.run.linux.x64.checked.mch	-0.03%
libraries.crossgen2.linux.x64.checked.mch	-0.02%
benchmarks.run_pgo.linux.x64.checked.mch	-0.02%

MinOpts (-0.07% to -0.04%)

Collection	PDIFF
smoke_tests.nativeaot.linux.x64.checked.mch	-0.05%
benchmarks.run.linux.x64.checked.mch	-0.06%
realworld.run.linux.x64.checked.mch	-0.05%
libraries_tests.run.linux.x64.Release.mch	-0.06%
benchmarks.run_tiered.linux.x64.checked.mch	-0.06%
libraries_tests_no_tiered_compilation.run.linux.x64.Release.mch	-0.05%
libraries.pmi.linux.x64.checked.mch	-0.04%
coreclr_tests.run.linux.x64.checked.mch	-0.04%
libraries.crossgen2.linux.x64.checked.mch	-0.07%
benchmarks.run_pgo.linux.x64.checked.mch	-0.06%

FullOpts (-0.02% to -0.01%)

Collection	PDIFF
smoke_tests.nativeaot.linux.x64.checked.mch	-0.02%
benchmarks.run.linux.x64.checked.mch	-0.01%
realworld.run.linux.x64.checked.mch	-0.01%
libraries_tests.run.linux.x64.Release.mch	-0.01%
benchmarks.run_tiered.linux.x64.checked.mch	-0.01%
libraries_tests_no_tiered_compilation.run.linux.x64.Release.mch	-0.01%
libraries.pmi.linux.x64.checked.mch	-0.01%
coreclr_tests.run.linux.x64.checked.mch	-0.01%
libraries.crossgen2.linux.x64.checked.mch	-0.02%
benchmarks.run_pgo.linux.x64.checked.mch	-0.01%

Details here

ryujit-bot · 2024-01-25T00:16:10Z

Diff results for #92974

Throughput diffs

Throughput diffs for linux/x64 ran on windows/x64

Overall (+0.00% to +0.01%)

Collection	PDIFF
benchmarks.run.linux.x64.checked.mch	+0.01%
benchmarks.run_pgo.linux.x64.checked.mch	+0.01%
benchmarks.run_tiered.linux.x64.checked.mch	+0.01%
coreclr_tests.run.linux.x64.checked.mch	+0.01%
libraries.pmi.linux.x64.checked.mch	+0.01%
libraries_tests.run.linux.x64.Release.mch	+0.01%
libraries_tests_no_tiered_compilation.run.linux.x64.Release.mch	+0.01%
realworld.run.linux.x64.checked.mch	+0.01%

MinOpts (+0.01% to +0.03%)

Collection	PDIFF
benchmarks.run.linux.x64.checked.mch	+0.03%
benchmarks.run_pgo.linux.x64.checked.mch	+0.03%
benchmarks.run_tiered.linux.x64.checked.mch	+0.03%
coreclr_tests.run.linux.x64.checked.mch	+0.02%
libraries.crossgen2.linux.x64.checked.mch	+0.03%
libraries.pmi.linux.x64.checked.mch	+0.01%
libraries_tests.run.linux.x64.Release.mch	+0.03%
libraries_tests_no_tiered_compilation.run.linux.x64.Release.mch	+0.03%
realworld.run.linux.x64.checked.mch	+0.02%
smoke_tests.nativeaot.linux.x64.checked.mch	+0.01%

FullOpts (+0.00% to +0.01%)

Collection	PDIFF
benchmarks.run.linux.x64.checked.mch	+0.01%
benchmarks.run_pgo.linux.x64.checked.mch	+0.01%
benchmarks.run_tiered.linux.x64.checked.mch	+0.01%
libraries.pmi.linux.x64.checked.mch	+0.01%
libraries_tests.run.linux.x64.Release.mch	+0.01%
realworld.run.linux.x64.checked.mch	+0.01%

Throughput diffs for windows/x64 ran on windows/x64

Overall (-0.01% to -0.00%)

Collection	PDIFF
coreclr_tests.run.windows.x64.checked.mch	-0.01%
libraries.crossgen2.windows.x64.checked.mch	-0.01%
smoke_tests.nativeaot.windows.x64.checked.mch	-0.01%

MinOpts (-0.02% to +0.00%)

Collection	PDIFF
benchmarks.run_pgo.windows.x64.checked.mch	-0.01%
benchmarks.run_tiered.windows.x64.checked.mch	-0.01%
coreclr_tests.run.windows.x64.checked.mch	-0.01%
libraries.pmi.windows.x64.checked.mch	-0.02%
libraries_tests.run.windows.x64.Release.mch	-0.01%
realworld.run.windows.x64.checked.mch	-0.01%
smoke_tests.nativeaot.windows.x64.checked.mch	-0.02%

FullOpts (-0.01% to -0.00%)

Collection	PDIFF
libraries.crossgen2.windows.x64.checked.mch	-0.01%
smoke_tests.nativeaot.windows.x64.checked.mch	-0.01%

Details here

Throughput diffs for windows/x86 ran on windows/x86

Overall (+0.00% to +0.01%)

Collection	PDIFF
benchmarks.run_tiered.windows.x86.checked.mch	+0.01%
coreclr_tests.run.windows.x86.checked.mch	+0.01%
libraries.crossgen2.windows.x86.checked.mch	+0.01%
libraries.pmi.windows.x86.checked.mch	+0.01%
libraries_tests.run.windows.x86.Release.mch	+0.01%
libraries_tests_no_tiered_compilation.run.windows.x86.Release.mch	+0.01%
realworld.run.windows.x86.checked.mch	+0.01%

MinOpts (+0.01% to +0.02%)

Collection	PDIFF
benchmarks.run.windows.x86.checked.mch	+0.01%
benchmarks.run_pgo.windows.x86.checked.mch	+0.01%
benchmarks.run_tiered.windows.x86.checked.mch	+0.01%
coreclr_tests.run.windows.x86.checked.mch	+0.01%
libraries.crossgen2.windows.x86.checked.mch	+0.01%
libraries.pmi.windows.x86.checked.mch	+0.02%
libraries_tests.run.windows.x86.Release.mch	+0.01%
libraries_tests_no_tiered_compilation.run.windows.x86.Release.mch	+0.01%
realworld.run.windows.x86.checked.mch	+0.01%

FullOpts (+0.00% to +0.01%)

Collection	PDIFF
benchmarks.run_tiered.windows.x86.checked.mch	+0.01%
libraries.crossgen2.windows.x86.checked.mch	+0.01%
libraries.pmi.windows.x86.checked.mch	+0.01%
libraries_tests_no_tiered_compilation.run.windows.x86.Release.mch	+0.01%
realworld.run.windows.x86.checked.mch	+0.01%

Details here

Throughput diffs for linux/x64 ran on linux/x64

Overall (-0.03% to -0.01%)

Collection	PDIFF
libraries_tests_no_tiered_compilation.run.linux.x64.Release.mch	-0.01%
libraries.pmi.linux.x64.checked.mch	-0.01%
coreclr_tests.run.linux.x64.checked.mch	-0.03%
realworld.run.linux.x64.checked.mch	-0.01%
libraries.crossgen2.linux.x64.checked.mch	-0.02%
benchmarks.run_tiered.linux.x64.checked.mch	-0.03%
smoke_tests.nativeaot.linux.x64.checked.mch	-0.02%
benchmarks.run_pgo.linux.x64.checked.mch	-0.02%
libraries_tests.run.linux.x64.Release.mch	-0.02%
benchmarks.run.linux.x64.checked.mch	-0.01%

MinOpts (-0.07% to -0.04%)

Collection	PDIFF
libraries_tests_no_tiered_compilation.run.linux.x64.Release.mch	-0.05%
libraries.pmi.linux.x64.checked.mch	-0.04%
coreclr_tests.run.linux.x64.checked.mch	-0.04%
realworld.run.linux.x64.checked.mch	-0.05%
libraries.crossgen2.linux.x64.checked.mch	-0.07%
benchmarks.run_tiered.linux.x64.checked.mch	-0.06%
smoke_tests.nativeaot.linux.x64.checked.mch	-0.05%
benchmarks.run_pgo.linux.x64.checked.mch	-0.06%
libraries_tests.run.linux.x64.Release.mch	-0.06%
benchmarks.run.linux.x64.checked.mch	-0.06%

FullOpts (-0.02% to -0.01%)

Collection	PDIFF
libraries_tests_no_tiered_compilation.run.linux.x64.Release.mch	-0.01%
libraries.pmi.linux.x64.checked.mch	-0.01%
coreclr_tests.run.linux.x64.checked.mch	-0.01%
realworld.run.linux.x64.checked.mch	-0.01%
libraries.crossgen2.linux.x64.checked.mch	-0.02%
benchmarks.run_tiered.linux.x64.checked.mch	-0.01%
smoke_tests.nativeaot.linux.x64.checked.mch	-0.02%
benchmarks.run_pgo.linux.x64.checked.mch	-0.01%
libraries_tests.run.linux.x64.Release.mch	-0.01%
benchmarks.run.linux.x64.checked.mch	-0.01%

Details here

MichalPetryka · 2024-01-25T16:32:01Z

@jkotas I think the arm32 atomic helper issue should be fixed in a separate PR (I can take a look at using the safe LLVM helpers later today) so this should be ready to merge.

jkotas · 2024-01-25T16:37:16Z

Turns out a small bug in the helpers somehow trashed the stack.

What was this bug?

jkotas · 2024-01-25T16:38:20Z

/azp run runtime-coreclr outerloop, runtime-nativeaot-outerloop

azure-pipelines · 2024-01-25T16:38:47Z

Azure Pipelines successfully started running 2 pipeline(s).

MichalPetryka · 2024-01-25T16:39:00Z

Turns out a small bug in the helpers somehow trashed the stack.

What was this bug?

A missing cast to UINT8 from CHAR which was returned by InterlockedExchange8 which somehow overrode half of a long on stack with 0.

jkotas

Thank you for making this happen!

Implement Interlocked for small types.

4344057

Implements Interlocked.CompareExchange/Exchange for byte/sbyte/short/ushort. Uses an intrinsic on CoreCLR x64 and ARM64 and fallbacks for other platforms. Fixes dotnet#64658.

dotnet-issue-labeler bot added area-System.Threading new-api-needs-documentation labels Oct 3, 2023

ghost added the community-contribution Indicates that the PR has been added by a community member label Oct 3, 2023

Fix xarch assert

d282722

stephentoub reviewed Oct 3, 2023

View reviewed changes

src/libraries/System.Threading/tests/InterlockedTests.cs Show resolved Hide resolved

MichalPetryka added 3 commits October 4, 2023 01:42

Update PalRedhawkInline.h

4079320

Update PalRedhawkInline.h

dae9d66

Update threads.c

4b74dba

This was referenced Oct 4, 2023

3 System.Diagnostics tests failing - System.FormatException : The input is not a valid Base-64 #76140

Open

[7.0] Linux_bionic arm64 failure in Convert.cs causing FormatException in System.Diagnostics.Process tests #88756

Closed

MichalPetryka and others added 7 commits October 5, 2023 00:33

Simplify NAOT handling

c6935de

Fix build

095567c

Update atomic.h

35a812f

Update atomic.h

f55fb45

Update atomic.h

b1c6dde

Fix windows intrinsics

8e80946

Update comutilnative.cpp

a25a4a3

build-analysis bot mentioned this pull request Oct 5, 2023

[7.0][mono][arm64] futex-internal.h: No such file or directory - futex_wait_cancelable native crash in Microsoft.Extensions.Logging.Generators.Roslyn3.11.Tests #87444

Closed

Klotzi111 reviewed Oct 5, 2023

View reviewed changes

src/mono/mono/utils/atomic.h Show resolved Hide resolved

Fix Windows builds

da399ca

This was referenced Oct 5, 2023

Build crashes in System.Runtime.Serialization.SerializationGuard #92007

Closed

Tracking issue for CI build timeouts #76454

Closed

Update icall-def.h

79c07ff

This was referenced Oct 6, 2023

[wasm][debugger] Debugger tests getting randomly aborted on CI #89409

Open

The active test run was aborted. Reason: Test host process crashed dotnet/dnceng#451

Open

Test infra failure on iOS.Device.Aot.Test.WorkItemExecution CI leg #92792

Closed

Fix icall-def.h

7da080b

MichalPetryka mentioned this pull request Jan 24, 2024

ARM32 (and possibly some others) might take locks in Interlocked FCalls #97452

Open

Merge remote-tracking branch 'upstream/main' into small-interlocked

de8f617

build-analysis bot mentioned this pull request Jan 24, 2024

GC/API/Refresh/Refresh failing in outer loop runs #97437

Closed

MichalPetryka added 2 commits January 24, 2024 18:13

Cleanup, fix helper extension

7af81b3

Fix test corelib

72e5bf8

MihuBot mentioned this pull request Jan 24, 2024

[X64] [MichalPetryka] Implement Interlocked for small types. MihuBot/runtime-utils#229

Open

build-analysis bot mentioned this pull request Jan 24, 2024

slow macOS - "##[error]The job running on agent Azure Pipelines 9 ran longer than the maximum time of 60 minutes." dotnet/dnceng#1883

Open

3 tasks

jkotas approved these changes Jan 25, 2024

View reviewed changes

jkotas merged commit de9d791 into dotnet:main Jan 25, 2024
292 of 299 checks passed

kunalspathak mentioned this pull request Jan 27, 2024

Assertion failed 'emitVerifyEncodable(ins, size, dstReg, srcReg)' during 'Generate code' #97587

Closed

filipnavara mentioned this pull request Jan 27, 2024

[NativeAOT] ARM: Add RhpLockCmpXchg8 and RhpLockCmpXchg16 #97588

Merged

EgorBo mentioned this pull request Jan 29, 2024

Fix GT_XCHG for byte on x86 #97593

Merged

github-actions bot locked and limited conversation to collaborators Feb 25, 2024

Implement Interlocked for small types. #92974

Implement Interlocked for small types. #92974

Conversation

MichalPetryka commented Oct 3, 2023

dotnet-issue-labeler bot commented Oct 3, 2023

ghost commented Oct 3, 2023

jkotas commented Jan 24, 2024

MichalPetryka commented Jan 24, 2024 • edited Loading

jkotas commented Jan 24, 2024

MichalPetryka commented Jan 24, 2024

MichalPetryka commented Jan 24, 2024 • edited Loading

jkotas commented Jan 24, 2024

MichalPetryka commented Jan 24, 2024

ryujit-bot commented Jan 24, 2024

Throughput diffs

Throughput diffs for linux/x64 ran on windows/x64

Throughput diffs for windows/x64 ran on windows/x64

Throughput diffs for linux/x64 ran on linux/x64

Throughput diffs for windows/x86 ran on windows/x86

MichalPetryka commented Jan 24, 2024

ryujit-bot commented Jan 24, 2024

Throughput diffs

Throughput diffs for linux/x64 ran on windows/x64

Throughput diffs for linux/x64 ran on linux/x64

ryujit-bot commented Jan 24, 2024

Throughput diffs

Throughput diffs for linux/x64 ran on linux/x64

ryujit-bot commented Jan 25, 2024

Throughput diffs

Throughput diffs for linux/x64 ran on windows/x64

Throughput diffs for windows/x64 ran on windows/x64

Throughput diffs for windows/x86 ran on windows/x86

Throughput diffs for linux/x64 ran on linux/x64

MichalPetryka commented Jan 25, 2024

jkotas commented Jan 25, 2024

jkotas commented Jan 25, 2024

azure-pipelines bot commented Jan 25, 2024

MichalPetryka commented Jan 25, 2024 • edited Loading

jkotas left a comment

Choose a reason for hiding this comment

MichalPetryka commented Jan 24, 2024 •

edited

Loading

MichalPetryka commented Jan 24, 2024 •

edited

Loading

MichalPetryka commented Jan 25, 2024 •

edited

Loading