Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid a few array allocations with DefaultBinder #93115

Merged
merged 5 commits into from
Oct 11, 2023

Conversation

stephentoub
Copy link
Member

In places where we're not handing out a T[] and thus actually need a T[], we can instead just get a span from the ListBuilder<T> being used.

In places where we're not handing out a `T[]` and thus actually need a `T[]`, we can instead just get a span from the `ListBuilder<T>` being used.
@ghost
Copy link

ghost commented Oct 6, 2023

Tagging subscribers to this area: @dotnet/area-system-reflection
See info in area-owners.md if you want to be subscribed.

Issue Details

In places where we're not handing out a T[] and thus actually need a T[], we can instead just get a span from the ListBuilder<T> being used.

Author: stephentoub
Assignees: stephentoub
Labels:

area-System.Reflection

Milestone: -

Copy link
Member

@jkotas jkotas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@stephentoub stephentoub merged commit 565ee96 into dotnet:main Oct 11, 2023
172 of 175 checks passed
@stephentoub stephentoub deleted the avoidbinderalloc branch October 11, 2023 17:38
@ghost ghost locked as resolved and limited conversation to collaborators Nov 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants