Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/8.0][wasm] Update workload description to include target framework #93359

Merged

Conversation

radical
Copy link
Member

@radical radical commented Oct 11, 2023

Issue: #93314

Customer Impact

Disambiguates the workload description for the 8.0 workload, so instead of .NET WebAssembly build tools the user will see .NET WebAssembly build tools for net8.0. And that's the same for 6.0, and 7.0 wasm workloads.

Testing

Manual.

Risk

None. Just a change in description.

@radical radical added the arch-wasm WebAssembly architecture label Oct 11, 2023
@radical radical requested a review from lewing as a code owner October 11, 2023 18:07
@ghost
Copy link

ghost commented Oct 11, 2023

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

Issue: #93314

Author: radical
Assignees: -
Labels:

arch-wasm

Milestone: -

@ghost ghost assigned radical Oct 11, 2023
@radical
Copy link
Member Author

radical commented Oct 11, 2023

@marcpopMSFT do I need to change the corresponding localized descriptions?

@radical radical changed the title [wasm] Update workload description to include target framework [release/8.0][wasm] Update workload description to include target framework Oct 11, 2023
@marcpopMSFT
Copy link
Member

@marcpopMSFT do I need to change the corresponding localized descriptions?

@radical what's your process for localizing these? I think yes but I haven't actually tested out a localized VS install (on the CLI, we will display the localized description in dotnet workload search)

@radical
Copy link
Member Author

radical commented Oct 11, 2023

@marcpopMSFT do I need to change the corresponding localized descriptions?

@radical what's your process for localizing these? I think yes but I haven't actually tested out a localized VS install (on the CLI, we will display the localized description in dotnet workload search)

@lewing @steveisok ^

@carlossanlop
Copy link
Member

@radical can you please fill out the PR template in the description and send an email to Tactics requesting approval?

@radical
Copy link
Member Author

radical commented Oct 12, 2023

@marcpopMSFT do I need to change the corresponding localized descriptions?

@radical what's your process for localizing these? I think yes but I haven't actually tested out a localized VS install (on the CLI, we will display the localized description in dotnet workload search)

IIUC, we don't really have a process for that, or seem to update them really. I guess, it is only being done on VS side then.

@radical radical added Servicing-consider Issue for next servicing release review Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Oct 12, 2023
@radical
Copy link
Member Author

radical commented Oct 13, 2023

@carlossanlop this is ready.

@marcpopMSFT
Copy link
Member

I doubt the loc is done on the VS side as it probably uses the value from here. @joeloff do you know for sure how loc versions of VS work for workload descriptions/names?

@joeloff
Copy link
Member

joeloff commented Oct 13, 2023

I doubt the loc is done on the VS side as it probably uses the value from here. @joeloff do you know for sure how loc versions of VS work for workload descriptions/names?

There is no localization on the VS side because the component is built in the runtime repo and the tooling used to generate the setup authoring is unaware of the localization strings in the workload manifest package. It is a known issue. Fixing the strings in runtime will update the localization experience for CLI based installations only

@carlossanlop
Copy link
Member

@carlossanlop this is ready.

Let's merge this!

@carlossanlop carlossanlop merged commit 9e8d548 into dotnet:release/8.0 Oct 13, 2023
23 of 28 checks passed
@ghost ghost locked as resolved and limited conversation to collaborators Nov 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
arch-wasm WebAssembly architecture area-Build-mono Servicing-approved Approved for servicing release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants