[release/7.0][mono] Backport offsets-tool fixes for Xcode 15 compatibility #93543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akoeplinger
added
Servicing-consider
|
Tagging subscribers to this area: @directhex Issue DetailsFixes #93009 Customer ImpactOur official macOS builds in release/7.0 use an older Xcode for creating .NET 7 packages, but if we bump to a macOS build image which has Xcode 15 the mono build would fail because Xcode 15 contains some breaking changes. This PR fixes these issues and allows us to build with latest Xcode. We're already using these changes in main and 8.0. TestingManually validated building with Xcode 15.0 works. RiskLow, this is a build only change and makes sure we can build with newer Xcode versions.
|
This was referenced Oct 16, 2023
lambdageek
approved these changes
Oct 16, 2023
This was referenced Oct 16, 2023
carlossanlop
added
Servicing-approved
|
Approved by Tactics via email. |
carlossanlop
merged commit 19045fa
into
dotnet:release/7.0-staging
125 of 133 checks passed
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #93009
Backports relevant parts of #88261, #86256 and #87190
Customer Impact
Our official macOS builds in release/7.0 use an older Xcode for creating .NET 7 packages, but if we bump to a macOS build image which has Xcode 15 the mono build would fail because Xcode 15 contains some breaking changes.
This PR fixes these issues and allows us to build with latest Xcode. We're already using these changes in main and 8.0.
Testing
Manually validated building with Xcode 15.0 works.
Risk
Low, this is a build only change and makes sure we can build with newer Xcode versions.